Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qcheck rely #156

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
3 participants
@bandersongit
Copy link
Contributor

commented Apr 24, 2019

Basically just ported my work over from c-cube/qcheck#62 after we decided that it makes sense for this to live here

Open questions I see are

a) The seed printing logic is kinda weird, if ANY modules using qcheck rely cause the random seed to be generated, all failures will print that seed whether or not it was overridden for the specific matcher/run

b) Do we want a custom matchers and a non custom matchers API (currently both are implemented)

Custom matchers output (also very open to feedback here)

image

@kyldvs

kyldvs approved these changes Apr 26, 2019

Copy link
Contributor

left a comment

Awesome, looks good to me!

@bandersongit bandersongit force-pushed the qcheck-rely branch from 342acf9 to 58c01bb Apr 30, 2019

@facebook-github-bot
Copy link

left a comment

@bandersongit is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

Copy link

commented May 1, 2019

@bandersongit merged this pull request in 00143c9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.