Skip to content

Conversation

@JonyFang
Copy link
Contributor

@JonyFang JonyFang commented Nov 28, 2025

Summary

This PR makes QuickLayout accessible to developers using stable Xcode versions by downgrading the Swift tools version requirement.

Changes

  • Downgrade swift-tools-version from 6.2 to 6.0
  • Update swift-syntax dependency from 602.0.0 to 600.0.0
  • Fix Demo project iOS deployment target from 26.0 to 15.0

Rationale

  • Swift 6.2 requires Xcode 26, which is the latest version. Swift 6.0 (Xcode 16.0+) has broader adoption and allows more developers to use this library.
  • swift-syntax version must match the Swift tools version (600.x for Swift 6.0).
  • Demo iOS deployment target was 26.0, which is inconsistent with Package.swift's platforms: [.iOS(.v15)] declaration. Changed to 15.0 for consistency.

Verification

  • swift package resolve succeeds
  • xcodebuild -scheme QuickLayout -destination 'platform=iOS Simulator,name=iPhone 16' build succeeds
  • Demo project builds successfully

- Change swift-tools-version from 6.2 to 6.0, as Swift 6.2 requires
  Xcode 16.5 Beta which most developers don't have access to
- Update swift-syntax from 602.0.0 to 600.0.0 to match Swift 6.0
- Fix Demo iOS deployment target from 26.0 (non-existent) to 15.0,
  matching the platforms declaration in Package.swift
@meta-cla
Copy link

meta-cla bot commented Nov 28, 2025

Hi @JonyFang!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@constantine-fry
Copy link
Contributor

@JonyFang, thank you for working on it. Happy to merge it once you sign the CLA. Let me know if you concerns.

@JonyFang
Copy link
Contributor Author

@JonyFang, thank you for working on it. Happy to merge it once you sign the CLA. Let me know if you concerns.

Thanks for the quick response! I've already signed the CLA. The confirmation should appear shortly.

@meta-cla
Copy link

meta-cla bot commented Nov 28, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the cla signed label Nov 28, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 28, 2025

@constantine-fry has imported this pull request. If you are a Meta employee, you can view this in D88010997.

@meta-codesync
Copy link

meta-codesync bot commented Nov 28, 2025

@constantine-fry merged this pull request in f723e5a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants