Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add info about service-worker and HTTP caching headers into Firebase section #3659

Merged
merged 1 commit into from Jan 10, 2018

Conversation

bobrosoft
Copy link
Contributor

@bobrosoft bobrosoft commented Dec 29, 2017

Tricky issue, if you not aware on how service-workers work. Related to #2440

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@bobrosoft bobrosoft changed the title docs: add info about HTTP caching headers into Firebase section docs: add info about service-worker and HTTP caching headers into Firebase section Dec 29, 2017
@gaearon
Copy link
Contributor

gaearon commented Jan 9, 2018

Seriously, Firebase is still not doing this by default?

cc @addyosmani @jeffposnick Is this expected?

@bobrosoft
Copy link
Contributor Author

Seriously, Firebase is still not doing this by default?

@gaearon no, unfort :( And that thing is crucial when deploying to Firebase, because service-worker enabled in create-react-app by default.

@gaearon
Copy link
Contributor

gaearon commented Jan 9, 2018

This sounds a bit silly given that Firebase is a Google project and Google's the one pushing for service worker adoption.

@gaearon
Copy link
Contributor

gaearon commented Jan 9, 2018

(To clarify, I refer to the situation as silly, not your post)

@jeffposnick
Copy link
Contributor

This sounds a bit silly given that Firebase is a Google project and Google's the one pushing for service worker adoption.

I'll agree that it's silly/frustrating, but for different reasons: this configuration shouldn't be necessary anymore, as per the service worker specification, and is no longer necessary in Firefox, which has been updated to ignore HTTP caches for service workers by default.

Unfortunately, and as discussed elsewhere, Chrome hasn't yet made that change, though there is at least a changelist under review.

Adding this recommendation to the docs for the time being to account for the current behavior of Chrome couldn't hurt.

(I wouldn't expect Firebase to make changes to their hosting environment to accommodate Chrome's inconsistent-with-the-spec behavior at this point.)

@gaearon gaearon added this to the 1.0.18 milestone Jan 10, 2018
@gaearon gaearon merged commit d49744f into facebook:master Jan 10, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 10, 2018

Fair, thank you for explaining! I’m sorry I snapped a little.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants