Permalink
Switch branches/tags
Nothing to show
Commits on Aug 14, 2018
  1. Updated calls to IsNetboot after dependency change

    insomniacslk authored and facebook-github-bot committed Aug 14, 2018
    Summary: In insomniacslk/dhcp#122 we changed `IsNetboot` to become a method of `DHCPv6Message`. This patch reflects the change in DHCPLB
    
    Differential Revision: D9295631
    
    fbshipit-source-id: 679900c579f0a95e4d52dcdf4510893776cf6ba3
Commits on Aug 13, 2018
  1. improve error handling

    pmazzini authored and facebook-github-bot committed Aug 13, 2018
    Summary: Get the error type when logging an error in server mode instead of always using ErrServe.
    
    Reviewed By: pallotron
    
    Differential Revision: D9290352
    
    fbshipit-source-id: aaf148d46604f8e0c6b95cb8f9818cfdf0d25cff
  2. Fatal in case of duplicate algos name

    pallotron authored and facebook-github-bot committed Aug 13, 2018
    Summary: ditto
    
    Differential Revision: D9284910
    
    fbshipit-source-id: fc925dab966fcfa255f9bd2afa9ebc63fca76737
Commits on Aug 3, 2018
  1. update to match the latest changes in the dhcp library

    pmazzini authored and facebook-github-bot committed Aug 3, 2018
    Summary: rebase and rebuild dhcplb on top of the latest DHCP library changes
    
    Reviewed By: tfg13
    
    Differential Revision: D9147841
    
    fbshipit-source-id: bc5c7aabcacdeae2fae795ed6a4b5b44b47fbffa
Commits on Jul 31, 2018
  1. handle dhcpv4 server

    pmazzini authored and facebook-github-bot committed Jul 31, 2018
    Summary:
    Implement the `handleV4Server` method for calling the server handler when started in server mode.
    
    Also move the related v6 code to a `handleV6Server` method.
    
    Reviewed By: pallotron
    
    Differential Revision: D9044216
    
    fbshipit-source-id: 522fe041493d47b977e10cdfcea4a919f960ce1d
Commits on Jul 15, 2018
  1. update to match the latest changes in the dhcp library

    pmazzini authored and facebook-github-bot committed Jul 15, 2018
    Summary: rebase and rebuild dhcplb on top of the latest DHCP library changes
    
    Reviewed By: insomniacslk
    
    Differential Revision: D8851143
    
    fbshipit-source-id: 47f5f88c68aaade62c19f78a718f524c9d6615aa
Commits on Jul 10, 2018
  1. add configuration option for setting the reply addr

    pmazzini authored and facebook-github-bot committed Jul 10, 2018
    Summary:
    Add configuration option for setting the reply address.
    
    If non is configured or an invalid one is given, a local address is automatically chosen, same as before.
    
    Reviewed By: pallotron
    
    Differential Revision: D8734649
    
    fbshipit-source-id: 1dbfb960d11ed938eb9b46b0208990a53ad4f1ab
Commits on Jun 12, 2018
  1. use functions from the dhcp library

    pmazzini authored and facebook-github-bot committed Jun 12, 2018
    Summary: use IsNetboot function from the dhcp library
    
    Reviewed By: insomniacslk
    
    Differential Revision: D8355501
    
    fbshipit-source-id: cf96455a18c083bc1f7a4124a59913a9ab06dbf3
Commits on Jun 6, 2018
  1. log incoming packets

    pmazzini authored and facebook-github-bot committed Jun 6, 2018
    Summary: ditto
    
    Reviewed By: pallotron
    
    Differential Revision: D8224207
    
    fbshipit-source-id: 8eb0b51a9a221967f041e78d2ec8a22e6070b552
Commits on May 30, 2018
  1. process requested options

    pmazzini authored and facebook-github-bot committed May 30, 2018
    Summary: process requested options
    
    Reviewed By: pallotron
    
    Differential Revision: D7988487
    
    fbshipit-source-id: 350899e0491d740fee96c18985daa2a3718946a9
Commits on May 29, 2018
  1. make server mode configurable

    pmazzini authored and facebook-github-bot committed May 29, 2018
    Summary: pass the extra config options to the server handler
    
    Reviewed By: pallotron
    
    Differential Revision: D8179587
    
    fbshipit-source-id: 7e042b4cc2a02613f972769862a80b22e6190793
Commits on May 21, 2018
  1. enhance juniper vendor option parsing

    nemith authored and facebook-github-bot committed May 21, 2018
    Summary:
    Turns out that parsing Juniper VC get even more complicated.  There is
    a potential for older version of Junos to not return a serial number inside the
    VC and it is instead contained in the HostName option.
    
    This takes a bit more catious appoach parsing the end of the string fist and if
    no final seperator is found ('-') then it will place the hostname option as the
    serial number.
    
    Reviewed By: pallotron
    
    Differential Revision: D7954668
    
    fbshipit-source-id: 26f6cb8a202e7815a549f764c74d5968dec38784
Commits on May 11, 2018
  1. prepare for server mode

    pmazzini authored and facebook-github-bot committed May 11, 2018
    Summary:
    * Add server flag
    * Remove version from serverImp since it was redundant, it was already stored in the config
    * Make `handleConnection`, `handleRawPacketV4` and `handleRawPacketV6` methods of serverImp
    * Add a Handler interface that is going to be used for serving DHCP requests
    
    Reviewed By: pallotron, insomniacslk
    
    Differential Revision: D7758063
    
    fbshipit-source-id: a615ba1ec1402e836ace25470640961e96631a9e
Commits on May 8, 2018
  1. VendorData: Allow Juniper models with '-' in them

    nemith authored and facebook-github-bot committed May 8, 2018
    Summary:
    Juniper, in their infinite wisdom, chose a vendor class string that
    deliminates using the '-' character which is also found in thier model numbers.
    
    This changes the logic to look for the first and last deliminator (hopefully
    they never add dashes to serial numbers!) and everything in between is the
    model number.
    
    Reviewed By: pallotron
    
    Differential Revision: D7873684
    
    fbshipit-source-id: 5533a1221cd1dbc2d5654c8463cab08b2496df76
Commits on May 4, 2018
  1. identify netboot requests

    pmazzini authored and facebook-github-bot committed May 4, 2018
    Summary: identify netboot requests
    
    Reviewed By: insomniacslk
    
    Differential Revision: D7859816
    
    fbshipit-source-id: 4f23b683530d00f98a28931238d6a2ee2005ee21
Commits on May 2, 2018
  1. updated to match the latest changes in the dhcp library

    insomniacslk authored and facebook-github-bot committed May 2, 2018
    Summary: The DHCP library had a bunch of updates, so let's rebase and rebuild dhcplb on top of it.
    
    Differential Revision: D7844535
    
    fbshipit-source-id: 03f487f0c76d403cae4b3faa9737d7103f2b68b1
Commits on Apr 18, 2018
  1. Add dhcp4 Opt60 (vc) and Opt124 (vico) parsing to library

    nemith authored and facebook-github-bot committed Apr 18, 2018
    Summary:
    This adds a new message identifier VendorData which is derived from
    Opt60 and Opt124 parsing.  Right now the implemented parsers are based on
    vendor specific values for popular network devices.  This is for DHCPv4 for
    right now.  IPv6 will be added in a future diff.
    
    Reviewed By: pallotron
    
    Differential Revision: D7409930
    
    fbshipit-source-id: b80a0a76b86e96ba87a01f42e6549a287b28a731
Commits on Apr 11, 2018
  1. replace the dhcpv6 code with github.com/insomniacslk/dhcp/dhcpv6

    pmazzini authored and facebook-github-bot committed Apr 11, 2018
    Summary: Replace the dhcpv6 code with `github.com/insomniacslk/dhcp/dhcpv6`
    
    Reviewed By: pallotron, insomniacslk
    
    Differential Revision: D7485674
    
    fbshipit-source-id: 99d67da02af72224507094a539f70564e0fa6730
Commits on Mar 29, 2018
  1. fix travis error

    pmazzini authored and facebook-github-bot committed Mar 29, 2018
    Summary: fix travis error after latest changes in dhcp lib
    
    Reviewed By: pallotron
    
    Differential Revision: D7443250
    
    fbshipit-source-id: 65fa7d21cf0411fb498694b984bb8df558221a6e
  2. migrate to Andrea's dhcp lib

    pmazzini authored and facebook-github-bot committed Mar 29, 2018
    Summary: Replace `github.com/krolaw/dhcp4` with `github.com/insomniacslk/dhcp/dhcpv4`
    
    Reviewed By: pallotron
    
    Differential Revision: D7414352
    
    fbshipit-source-id: 1877c41fd106ce979ff4826f1a42f4de264441d9
Commits on Jan 30, 2018
  1. Remove T

    lclarkmichalek authored and facebook-github-bot committed Jan 30, 2018
    Summary: Remove T prefix from all symbols exported by Go Thrift
    
    Reviewed By: nemith
    
    Differential Revision: D6813654
    
    fbshipit-source-id: 74e1ef93e869b98725d7a330ec37da1168c1495c
Commits on Nov 16, 2017
  1. Make dhcpv4 handler more robust in the face of malformed packets

    pallotron authored and facebook-github-bot committed Nov 16, 2017
    Summary: The third party lib we use for dhcpv4 is not the best... apply some defensive coding.
    
    Reviewed By: martelli
    
    Differential Revision: D6347856
    
    fbshipit-source-id: f7588aa95ba5ef16da1ee23c31bb4984ad66cd69
Commits on Oct 31, 2017
  1. Fixing build, take 3

    pallotron authored and facebook-github-bot committed Oct 31, 2017
    Summary: ditto
    
    Reviewed By: avleen, insomniacslk
    
    Differential Revision: D6199377
    
    fbshipit-source-id: 870d0f32fe1651092d61b1efcb4a85677c1f902a
  2. Fix build, take 2

    pallotron authored and facebook-github-bot committed Oct 31, 2017
    Reviewed By: insomniacslk
    
    Differential Revision: D6198562
    
    fbshipit-source-id: 041064c26a888c77e38b85491c0321f5b517100b
  3. fix build issue

    pallotron authored and facebook-github-bot committed Oct 31, 2017
    Summary: Fixing the build, somehow I missed that in the previous refactoring.
    
    Differential Revision: D6197750
    
    fbshipit-source-id: 41e8c16ecabdf3ec61f155f5132eed0d78a092e1
  4. Provide a pluggable interface method that can be used to implement yo…

    pallotron authored and facebook-github-bot committed Oct 31, 2017
    …ur own algorithms
    
    Summary:
    Added a new `NewDHCPBalancingAlgorithm` method to the `ConfigProvider` interface.
    This allows users to implement their own special algorithms, w/o necessarily having to share
    the code publicly.
    
    Reviewed By: lsiudut, insomniacslk
    
    Differential Revision: D6171748
    
    fbshipit-source-id: d23a15fd34082ebb0fde594652c5e3d983698c9d
Commits on Aug 9, 2017
  1. New packet6.GetInnerMostPeerAddr to extract mac address from the inne…

    pallotron authored and facebook-github-bot committed Aug 9, 2017
    …rmost peer-address field of the relay message option.
    
    Summary:
    When you have multiple relay relaying messages you are going to end up with multiple relay message payloads stacked one on top of the other. this diff adds a new public function called GetInnerMostPeerAddr which provides the peer address fields of the relay information closest to the DHCP Client, that typically is set to the EUI-64 IPv6 address by the cloest relay to the client.
    We currently use that to infer the mac address for a client, even if the client doesn't use DUID-LL[T].
    
    Reviewed By: rb2k, malmond77, nemith
    
    Differential Revision: D5592407
    
    fbshipit-source-id: 92a1079cd3b49290c0921746b789f092b0934626
Commits on Aug 4, 2017
  1. Extract mac address from non DUID-LL[T] requests using relayinfo's EU…

    pallotron authored and facebook-github-bot committed Aug 4, 2017
    …I-64 address in peer-address field, if present
    
    Summary:
    DUID-EN or DUID-UUID are client ids that don't contain mac address information in them, dhcplb can still extract the mac address by looking at the RelayInfo header in RelayFwd messages, the peer-address field there contains an EUI-64 address.
    
    It is possible to extract the mac address from there.
    
    See https://supportforums.cisco.com/document/100566/understanding-ipv6-eui-64-bit-address
    
    We do that using https://github.com/mdlayher/eui64
    
    Reviewed By: fiorix
    
    Differential Revision: D5562502
    
    fbshipit-source-id: f33bcdd734cd0bad06843945c8e829f71e901d8e
Commits on Jun 20, 2017
  1. dhcplb: Fix overrides scope error

    Natolumin authored and facebook-github-bot committed Jun 20, 2017
    Summary:
    This overrides variable was misscoped and overrides were ignored everywhere.
    The logging was in the wrong place and mistakenly reported overrides that were ignored
    
    Reviewed By: pallotron
    
    Differential Revision:
    D5282765
    
    Tags: dhcplb-opensource, dhcplb
    
    fbshipit-source-id: 0508f332c65788ace0afdb7050b0252deb9c84f1
Commits on Jun 19, 2017
  1. Allow passing config from strings

    Natolumin authored and facebook-github-bot committed Jun 19, 2017
    Summary:
    Add a ParseConfig function to allow building a configuration from json
    strings, instead of only files, to allow pulling configuration from a service
    returning JSON without needing to write it to a file, especially when using
    dhcplb as a library.
    
    Reviewed By: pallotron
    
    Differential Revision: D5255982
    
    fbshipit-source-id: 165f93a68ff13b4e1d12080a61c7617dd1960210
Commits on May 11, 2017
  1. Support for timed overrides

    marcoguerri authored and facebook-github-bot committed May 11, 2017
    Summary:
    This change adds support for expiration of override rules. This is intended to
    be used by dhcplb to decide whether or not an override rule should be ignored.
    
    Reviewed By: pallotron
    
    Differential Revision: D5015330
    
    fbshipit-source-id: 6ff8f546fdc4cef2a8434d2bdf63483934998e37
Commits on Mar 24, 2017
  1. Edit README.md

    Keizar901 authored and facebook-github-bot committed Mar 24, 2017
    Summary: Closes #18
    
    Reviewed By: pallotron
    
    Differential Revision: D4769808
    
    Pulled By: insomniacslk
    
    fbshipit-source-id: 472ea9601c30a0ca2193174c1248b6f6ed45fdda
Commits on Mar 7, 2017
  1. Resolve ILA IP into svc hostname and make SMC client more robust

    pallotron authored and facebook-github-bot committed Mar 7, 2017
    Summary:
    Using the new function created in D4665049
    Also I have noticed some issues with SMC client lately
    
    ```
    E0306 19:51:26.167725 4016226 update_servers.go:32] Error calling GetFilteredTierByName(). Error: `read tcp 127.0.0.1:53668->127.0.0.1:1421: read: connection reset by peer`
    ```
    
    They are transient, I dunno what's going on, but in the meantime I am making the SMC query more robust
    
    Reviewed By: lsiudut, mkaczanowski
    
    Differential Revision: D4665117
    
    fbshipit-source-id: 0989a46b74025001be058c4388b81a41829b5a48
  2. Print IPs and hostnames in logs

    pallotron authored and facebook-github-bot committed Mar 7, 2017
    Summary: all in the title.
    
    Reviewed By: shish
    
    Differential Revision: D4665103
    
    fbshipit-source-id: 31c272d889fbaed05262b0682c84aa63640bd2fa
Commits on Dec 1, 2016
  1. fix if condition in Test_ThrottleCacheRateFail

    motomuman authored and Facebook Github Bot committed Dec 1, 2016
    Summary:
    I think Test_ThrottleCacheRateFail expects throttle.OK(key) return fail when query exceeds cache rate limiting.
    Closes #17
    
    Differential Revision: D4259998
    
    Pulled By: pallotron
    
    fbshipit-source-id: da3a720f90788859c5504ab7dec69460b2d6b584