Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with client and server commands #13

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@agnosticdev
Copy link
Contributor

commented May 15, 2019

Update README echo server sample commands.
The IPv6 localhost address ::1 was added on the client and the -host argument was removed on the server because this is the default address by default.

Update README with client and server commands
Update README echo server sample commands. 
The IPv6 localhost address `::1` was added on the client and the `-host` argument was removed on the server because this is the default address by default.
@agnosticdev

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

Relates to issue #11

@udippant

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

While you are at it, can you propagate the FLAGS_host to EchoServer (like we do for EchoClient) and bind to the passed in address (while keeping the default address to ::1) :)?

@agnosticdev

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

I will start looking into that. Upon completion that will require an update to the README file again so I will make an update to the client and server commands as well.

@agnosticdev

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@udippant This PR has been updated with FLAGS_host propagating to the EchoServer.

@facebook-github-bot
Copy link

left a comment

@udippant has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@udippant

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Thank you! We will review it internally and merge it back.

@agnosticdev

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

Is there any action needed from me on this PR at this time?

@udippant

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

@agnosticdev I have merged it back. Thank you for contributing.

@agnosticdev

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

Thank you @udippant !

@facebook-github-bot

This comment has been minimized.

Copy link

commented May 17, 2019

@udippant merged this pull request in fe66d5c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.