Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use pipenv for Travis builds #18

Conversation

Projects
None yet
2 participants
@calebmarchent
Copy link
Contributor

calebmarchent commented Dec 14, 2018

Using language "python" in Travis starts up within a virtualenv; current
version of pipenv does not like to be run within an existing virtualenv;
we do require the pipenv library, to get dependencies, as we require
nose for the unit tests; so these are installed manually for the travis
job.

@calebmarchent calebmarchent force-pushed the calebmarchent:dont_use_pipenv_for_travis branch from 1095c5f to 8f55186 Dec 14, 2018

Don't use pipenv for Travis builds
Using language "python" in Travis starts up within a virtualenv; current
version of pipenv does not like to be run within an existing virtualenv;
we do require the pipenv library, to get dependencies, as we require
nose for the unit tests; so these are installed manually for the travis
job.

Fixes #17

@calebmarchent calebmarchent force-pushed the calebmarchent:dont_use_pipenv_for_travis branch from 8f55186 to 1df744a Dec 14, 2018

@facebook-github-bot
Copy link
Contributor

facebook-github-bot left a comment

@calebmarchent has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.