Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes bug described in #308
This bug causes wrap-around errors in 3+ party division. Upon inspection, it became clear that this bug is caused by a change in the scaling logic introduced in D29064976 (a632bf4).
This bug happened because the correction applied to wraps has different scaling than the input tensor, and the new logic rescales accordingly. This can be fixed by applying the arithmetic on the shares rather than the ASTs.
To ensure bugs like this won't be reproduced again, I've introduced 3PC tests into test_mpc.py as well. These will increase runtime of the test harness, making it more necessary to upgrade the testing framework for easier submissions.
Differential Revision: D31206649