Add asset integrity check for asset downloads#840
Merged
cbalioglu merged 6 commits intoNov 22, 2024
Conversation
Contributor
Author
|
I added a check to see if the checksum is |
cbalioglu
added a commit
that referenced
this pull request
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? Please describe:
This PR adds a file integrity check for tokenizers, models, and datasets to ensure they were downloaded properly with a SHA-1 checksum. If the checksum listed on the asset card doesn't match, the
download_managerwill raise anAssetDownloadError. If there is no listed checksum on the asset card, thedownload_managerwill proceed like normal but make a call tolog.warningabout the missing checksum field.Fixes #839
Does your PR introduce any breaking changes? If yes, please list them:
Adds an additional
checksumparameter to thedownload_manager's methods for downloading tokenizers, models, and datasets.Check list: