Added variables to build bindings when using VCPKG #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ahmadsocrat! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
@tlikhomanenko has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@tlikhomanenko merged this pull request in fa9649f. |
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 25, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 27, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 27, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 27, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/text
that referenced
this pull request
Mar 27, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/sequence
that referenced
this pull request
Oct 13, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/sequence
that referenced
this pull request
Oct 13, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/sequence
that referenced
this pull request
Oct 13, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
jacobkahn
pushed a commit
to flashlight/sequence
that referenced
this pull request
Oct 13, 2022
Summary: **Original Issue**: flashlight/flashlight#437 Missing documentation for building python bindings when using VCPKG to build flashlight ### Test Plan (required) None, documentation change only Pull Request resolved: flashlight/flashlight#440 Reviewed By: avidov Differential Revision: D26106659 Pulled By: tlikhomanenko fbshipit-source-id: e9bf3eb18444f28d354631c9ffa7829f52b888b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Issue: #437
Summary
Missing documentation for building python bindings when using VCPKG to build flashlight
Test Plan (required)
None, documentation change only