Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Contributing file #1

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

facebook-github-bot
Copy link
Contributor

This is pull request was created automatically because we noticed your project was missing a Contributing file.

CONTRIBUTING files explain how a developer can contribute to the project - which you should actively encourage.

This PR was crafted with love by Facebook's Open Source Team.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 31, 2020
@amoghavs amoghavs merged commit 4b7fd37 into master Jul 31, 2020
facebook-github-bot pushed a commit that referenced this pull request Nov 12, 2021
Summary:
set master-ip and master-port with the following logic
1. prefer the values passed to PARAM, i.e., through --master-ip and --master-port
2. check and use the env. variable, i.e., MASTER_ADDR and MASTER_PORT
3. if both #1 and #2 are not set, use the pre-defined default values

handle local_rank=-1 when setting cuda device -> print out warning and set to 0

Reviewed By: bryanmr

Differential Revision: D32377044

fbshipit-source-id: ed27ac959cc7abf8555afc6890f537379c56e9a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants