Improve benchmark runtime with data check #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergei-Lebedev
requested review from
kingchc,
naghshineh and
srinivas212
as code owners
facebook-github-bot
added
the
CLA Signed
|
@kingchc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
kingchc
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fast path to data check to see if tensors are different first.
Allgather 8 Ranks with data check without optimization
CPU --b 1K --e 1M: 52.046s
GPU --b 1K --e 2M: 8m 29.476s
Allgather 8 Ranks with data check with optimization
CPU --b 1K --e 1M: 7.730s
GPU --b 1K --e 2M: 8.375s
Also fixes "IndexError: list index out of range" for collectives with list of tensors when tensors are not equal