Updating the arguments to accept DLRM like MLP config. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Updating the linear benchmark to accept the layer configs similar to DLRM, as a dash separated int string. This simplifies benchmarking components and specifying such benchmarks with vendors. To maintain the current arguments, the `layers_size` argument is added which takes precedence. Either way of specifying the config will first put the config in `laters_size` array, on which the rest of the functions operate. Reviewed By: nrsatish Differential Revision: D36029864 fbshipit-source-id: 517d859241d3c053ad501b17927947c986b0c4ab
ehsanardestani
requested review from
srinivas212,
naghshineh and
kingchc
as code owners
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D36029864 |
|
Already committed internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updating the linear benchmark to accept the layer configs similar to DLRM, as a dash separated int string. This simplifies benchmarking components and specifying such benchmarks with vendors.
To maintain the current arguments, the
layers_sizeargument is added which takes precedence. Either way of specifying the config will first put the config inlaters_sizearray, on which the rest of the functions operate.Reviewed By: nrsatish
Differential Revision: D36029864