Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

How is the simulated video length related to the object states? #78

Closed
Wuziyi616 opened this issue Sep 1, 2022 · 3 comments
Closed

Comments

@Wuziyi616
Copy link

Hi, thanks for open-sourcing this great work. I have a question regarding the simulated video length. I went through several videos generated by

sim = simulator.simulate_action(task_id, act, stride=60, ...)
video = sim.images

The length of the generated videos varies a lot (seems to be from 6 to 18 or so). So I wonder how is the length determined? I look at the video, it seems that the video ends 3 seconds after the object-of-interest (green and blue/purple ones) come to stable states (e.g. stop moving and in contact)? Is this observation correct? Thanks!

@Wuziyi616 Wuziyi616 changed the title How is simulated video length related to the object states? How is the simulated video length related to the object states? Sep 1, 2022
@Wuziyi616 Wuziyi616 changed the title How is the simulated video length related to the object states? How is the simulated video length related to the object states? (Possibly wrong SOLVED label?) Sep 1, 2022
@Wuziyi616
Copy link
Author

Wuziyi616 commented Sep 1, 2022

I went through some tasks in the within protocol, fold 0 test set data. I found some task-action pairs which are labeled as SOLVED very weird, it seems that the simulated videos end before the objects enter stable states, leading to wrong labels.

Examples:

  • task 230, act 20: mp4
  • task 236, act 393: mp4

My conjecture is that, the simulator sees the cyan and the blue object in contact lasting for 3s, so it assumes the simulation should end and assign a SOLVED label? The good news is, it seems that most of such errors (if they indeed are) only happen in this one task family.

Another possibility is that I misunderstood the goal condition. Should the goal state be a stable state, or if the two target objects just touch each other once and then separate is still considered a success?

@akhti
Copy link
Contributor

akhti commented Sep 2, 2022

Hi there!
The condition for task being marked as solved is whether two target objects are in touching relation for 3 seconds. It does allow for some weird solutions where the objects are not stable but still are in contact for 3 seconds. That is pretty rare though

@Wuziyi616 Wuziyi616 changed the title How is the simulated video length related to the object states? (Possibly wrong SOLVED label?) How is the simulated video length related to the object states? Sep 2, 2022
@Wuziyi616
Copy link
Author

I agree, it's indeed very rare. I train a model only looking at the last frame to determine whether the task is solved, and can achieve 99% accuracy.
Thanks for the answer!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants