New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore generated documentation sources in git #162

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@m3rlin45
Copy link
Contributor

m3rlin45 commented Dec 27, 2018

Summary:
We generate a lot of source files as part of our documentation build process. These are generated files and should not be checked in
Test Plan:

ran make html and confirmed that git was not tracking the files

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Ignore generated documentation sources in git
Summary:
We generate a lot of source files as part of our documentation build process. These are generated files and should not be checked in
Test Plan:

ran `make html` and confirmed that git was not tracking the files
@facebook-github-bot
Copy link
Contributor

facebook-github-bot left a comment

@m3rlin45 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot left a comment

@bethebunny is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment