New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gets rid of all doc gen warnings for Python 3.7 #188

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@snisarg
Copy link
Contributor

snisarg commented Jan 4, 2019

Motivation and Context

This fixes the error that was preventing doc generation in Python 3.7. Note that doc generation will still throw a warning for 3.6, but a lot of time has been spent trying to fix that by Chris and me and moving ahead is the best approach anyway. Therefore, this commit also updates doc generation on CircleCI and ReadTheDocs to Python 3.7. Finally, enabling failures on warning for Sphinx doc gen so we lock this down for good.

How Has This Been Tested

Tested by building docs locally without errors

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
Gets rid of all doc gen warnings for Python 3.7
This fixes the error that was preventing doc generation in Python 3.7. Note that doc generation will still throw a warning for 3.6, but a lot of time has been spent trying to fix that by Chris and me and moving ahead is the best approach anyway. Therefore, this commit also updates doc generation on CircleCI and ReadTheDocs to Python 3.7. Finally, enabling failures on warning for Sphinx doc gen so we lock this down for good.
@facebook-github-bot
Copy link
Contributor

facebook-github-bot left a comment

@snisarg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot left a comment

@snisarg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

Copy link
Contributor

facebook-github-bot commented Jan 8, 2019

@snisarg has updated the pull request. Re-import the pull request

@facebook-github-bot
Copy link
Contributor

facebook-github-bot left a comment

@snisarg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

Copy link
Contributor

facebook-github-bot commented Jan 8, 2019

@snisarg has updated the pull request. Re-import the pull request

@facebook-github-bot
Copy link
Contributor

facebook-github-bot left a comment

@snisarg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

This comment has been minimized.

Copy link
Contributor

facebook-github-bot commented Jan 8, 2019

@snisarg has updated the pull request. Re-import the pull request

@facebook-github-bot

This comment has been minimized.

Copy link
Contributor

facebook-github-bot commented Jan 8, 2019

@snisarg has updated the pull request. Re-import the pull request

@facebook-github-bot
Copy link
Contributor

facebook-github-bot left a comment

@snisarg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@snisarg snisarg deleted the doc_no_warnings branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment