Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Migrate Wit workflows to new data design, delete WordTaggingTask_Deprecated and WordTaggingModel #910

Closed
wants to merge 1 commit into from

Conversation

geof90
Copy link
Contributor

@geof90 geof90 commented Aug 15, 2019

Summary: as title

Differential Revision: D16827032

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 15, 2019
geof90 added a commit to geof90/pytext that referenced this pull request Aug 15, 2019
…ecated and WordTaggingModel (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 9e4af976486ac7d08d1c7dcdebfd0cb9170e4107
geof90 added a commit to geof90/pytext that referenced this pull request Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: c400223c92151125b82171b0e5d7f3cb4b134215
geof90 added a commit to geof90/pytext that referenced this pull request Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 60571f784199ccd27af349ccc554ff8af7975dd4
@geof90 geof90 force-pushed the export-D16827032 branch 2 times, most recently from 6419d78 to 3609a1a Compare August 16, 2019 10:54
geof90 added a commit to geof90/pytext that referenced this pull request Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: a033562c89ff3578959fa7bf3eaa95e16e7b8b81
geof90 added a commit to geof90/pytext that referenced this pull request Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 2f3911f6e39ac62da54a874f5a0a4c7ff17ae1cc
geof90 added a commit to geof90/pytext that referenced this pull request Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: fd9726e72eb048b11ec2c6e5c1e4ecab22c5b8a5
@geof90 geof90 force-pushed the export-D16827032 branch 2 times, most recently from 7998ef3 to 850c86e Compare August 16, 2019 21:54
geof90 added a commit to geof90/pytext that referenced this pull request Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 1339aaf9713178e5f3cb02c76811abf9095e2a33
geof90 added a commit to geof90/pytext that referenced this pull request Aug 16, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 7d558648f59e5e1db840890d9adca4e87e56eaec
@geof90 geof90 force-pushed the export-D16827032 branch 2 times, most recently from 0eb4009 to 8aa937c Compare August 17, 2019 07:59
geof90 added a commit to geof90/pytext that referenced this pull request Aug 17, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 4a32a1db4c4ffe4c973efffae76cdb6b81e5c300
geof90 added a commit to geof90/pytext that referenced this pull request Aug 17, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: b386c9969e97b038196dc952c1d96d7765e0c5fe
geof90 added a commit to geof90/pytext that referenced this pull request Aug 17, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 713f18773b47b76be8110f6d40e1284c142a8d76
geof90 added a commit to geof90/pytext that referenced this pull request Aug 18, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 08509c90b076ed94c6e45cf27a27e65b5763abd9
geof90 added a commit to geof90/pytext that referenced this pull request Sep 3, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: bc3a920959522608a3f115f9d813f2745cdd48f6
geof90 added a commit to geof90/pytext that referenced this pull request Sep 3, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 169b9cd5b5a26a3a4fadbbcfd638e7b098412578
@geof90 geof90 force-pushed the export-D16827032 branch 2 times, most recently from 5ab4933 to 207ed9b Compare September 5, 2019 13:27
geof90 added a commit to geof90/pytext that referenced this pull request Sep 5, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 9c3710abf1055d4102114548f487b9c79b41da4e
geof90 added a commit to geof90/pytext that referenced this pull request Sep 5, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 75cd72b21b9f4ed42b4378ed02ff953b1d4971fc
geof90 added a commit to geof90/pytext that referenced this pull request Sep 5, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 3e5aa85ce72c22111ba1732b4de8b3691480118b
geof90 added a commit to geof90/pytext that referenced this pull request Sep 5, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 6e0a90f7bdad2033c8e8fce35201e41fe65d3fb3
geof90 added a commit to geof90/pytext that referenced this pull request Sep 5, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 3470b7b94a5add59673988c37110a00c397b1603
geof90 added a commit to geof90/pytext that referenced this pull request Sep 5, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: d6b473f9f779943bd8e0b01b7e2d8b0e4540ef6a
@geof90 geof90 force-pushed the export-D16827032 branch 2 times, most recently from 2949317 to a4024c7 Compare September 9, 2019 22:39
geof90 added a commit to geof90/pytext that referenced this pull request Sep 9, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: f04909143270fed2282c6f0452231b1b6a5357a6
geof90 added a commit to geof90/pytext that referenced this pull request Sep 10, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Differential Revision: D16827032

fbshipit-source-id: 29f9e7eebcd25accd93b39c14b3cdf6d3efcd3e9
geof90 added a commit to geof90/pytext that referenced this pull request Sep 10, 2019
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Reviewed By: seayoung1112

Differential Revision: D16827032

fbshipit-source-id: c692ebcd9d6ce140229a267480e8306cabf9b9ad
…ing tasks, models and data handlers (facebookresearch#910)

Summary:
Pull Request resolved: facebookresearch#910

as title

Reviewed By: seayoung1112

Differential Revision: D16827032

fbshipit-source-id: 101d0c76455ad7243b4d9fdd62df9f2b6c5803a6
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ee59a74.

facebook-github-bot pushed a commit that referenced this pull request Nov 14, 2019
Summary:
Pull Request resolved: fairinternal/fairseq-py#910

Pull Request resolved: #1124

Pull Request resolved: facebookresearch/fairseq#1362

Split the Fariseq MemoryEfficientFP16Optimizer class into 2 classes so that it can be easily imported in pytext through a wrapper class.

Iter 2 - fixed some issues to ensure code runs correctly on fblearner.

Iter 3 - fixed review comments, incorrect import and lints.

Iter 4 - fixed pytext test breaks.

Iter 5 - fix pytext test breaks.

Iter 6 - fix comments and refactor based on conversation with chenyang.

Reviewed By: chenyangyu1988

Differential Revision: D18410916

fbshipit-source-id: 5238ee553cd2811ed0573825e1c29000980cc489
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants