This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
config adapter old data handler helper #943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Titousensei
force-pushed
the
export-D17123513
branch
from
16d186f
to
7e86648
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Sep 9, 2019
Summary: Pull Request resolved: facebookresearch#943 split remove_lmtask_deprecated to be able to re-use the code that adapts most of old data handler parameters to new. Reviewed By: hudeven Differential Revision: D17123513 fbshipit-source-id: 6199d34dbea8a29e36d2d3f386ce9e230a2b4363
Titousensei
force-pushed
the
export-D17123513
branch
from
7e86648
to
811df47
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Sep 10, 2019
Summary: Pull Request resolved: facebookresearch#943 split remove_lmtask_deprecated to be able to re-use the code that adapts most of old data handler parameters to new. Reviewed By: hudeven Differential Revision: D17123513 fbshipit-source-id: bbf79f19394403184e571d29ed37505a9685f343
Titousensei
force-pushed
the
export-D17123513
branch
from
811df47
to
a2f9d9f
Compare
Summary:
nicer internal API for gen_config_impl. You can now call
gen_config_impl() with args and kwargs, which is a better syntax than string
when calling from python. Since python parameter names can't contain ".",
you still need to use string in this case.
For example,
cfg = gen_config_impl("LMTask", field_names=["text"])
cfg = gen_config_impl("LMTask", "decoder.embed_dim=10")
Differential Revision: D17123234
fbshipit-source-id: e2c4f022c4c2448b9eeca5c2ee684262b1879138
Summary: Pull Request resolved: facebookresearch#943 split remove_lmtask_deprecated to be able to re-use the code that adapts most of old data handler parameters to new. Reviewed By: hudeven Differential Revision: D17123513 fbshipit-source-id: e1794fe50c521d58d8b9bc9577b7eb72c7876a1e
Titousensei
force-pushed
the
export-D17123513
branch
from
a2f9d9f
to
68250ee
Compare
|
This pull request has been merged in c56b826. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
split remove_lmtask_deprecated to be able to re-use the code that
adapts most of old data handler parameters to new.
Differential Revision: D17123513