-
Notifications
You must be signed in to change notification settings - Fork 121
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updated Lie labs example with v3 of the API.
- Loading branch information
Showing
1 changed file
with
56 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you Luis, it looks great!
I have a minor comment.
For
LieTensor.new()
, should it share storage?For example,
tensor.new_tensor
always copies the data, and I think the term new sort of implies that, and I think it would be nicer if we kept consistent.Also, I'm not sure how exactly I should read this line.
x.new(data)
isn't very intuitive, maybe something likex.new_lietensor
is more clear (similar to new_tensor)