-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ellipsoidal damping for SparseSolver #35
Comments
Very hard to fix using Cholmod on CPU! The reason is that we only give A to Cholmod, and it will compute At*A internally, plus possibly spherical damping. The new CUDA LU-based solver will support ellipsoidal damping from the beginning. |
Do we have an error in place for this? For consistency, we should probably allow the user to pass this parameter when using Cholmod and either throw an error/warning somewhere. |
Agreed, we should raise an error here. There are other possible places where we need such errors to account for incompatible combinations of solvers/supported settings. Maybe flag a separate issue to do a sweep for these. We can close this issue if the sparse and dense LU solvers both already supports this. |
@maurimo I forgot what the status of this. Can you remind me which of our sparse solvers (if any) currently support this? |
Can work on Cuda-LU, will work with BaSpaCho (as Jt x J is/will be computed externally), no chance with Cholmod as it's computing Jt x J internally (adding only possibly one constant to the diagonal). To make it work with Cholmod need to implement externally the operation Jt x J (but I think BaSpaCho will prove to superseed Cholmod also as CPU-only solver). |
A' = A + damping * diag(A + eps)
The text was updated successfully, but these errors were encountered: