Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jacobians argument to exp_map and log_map functions #122

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Add jacobians argument to exp_map and log_map functions #122

merged 1 commit into from
Mar 16, 2022

Conversation

joeaortiz
Copy link
Contributor

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 16, 2022
fantaosha
fantaosha approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@fantaosha fantaosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhmukadam mhmukadam added the refactor Refactor library components label Mar 16, 2022
luisenp
luisenp approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@luisenp luisenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this!

@mhmukadam mhmukadam merged commit 99f88f9 into main Mar 16, 2022
@mhmukadam mhmukadam deleted the joe.exp_log_map_jacobians branch March 16, 2022 20:48
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@joeaortiz
jacobian optional argument to exp_map and log_map (facebookresearch#122)
8fd4e6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisenp luisenp luisenp approved these changes

@mhmukadam mhmukadam mhmukadam approved these changes

@fantaosha fantaosha fantaosha approved these changes

Assignees

@joeaortiz joeaortiz

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. refactor Refactor library components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joeaortiz @luisenp @mhmukadam @fantaosha @facebook-github-bot