Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dtype error in se3.py that came up in unit tests #158

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Fixed dtype error in se3.py that came up in unit tests #158

merged 2 commits into from
Apr 14, 2022

Conversation

joeaortiz
Copy link
Contributor

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 13, 2022
luisenp
luisenp approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@luisenp luisenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM, just curious if where wouldn't accept a scalar tensor rather than having to call full.

@fantaosha
Copy link
Contributor

Thanks for the fix! LGTM, just curious if where wouldn't accept a scalar tensor rather than having to call full.

That's also what I thought. How about
torch.tensor(-1/12.0, dtype=sine_by_theta.dtype, device=sine_by_theta.device).

fantaosha
fantaosha requested changes Apr 13, 2022
View reviewed changes
theseus/geometry/se3.py Show resolved Hide resolved
theseus/geometry/se3.py Show resolved Hide resolved
@luisenp luisenp merged commit db53161 into main Apr 14, 2022
@luisenp luisenp deleted the joe.se3_dtype_fix branch April 14, 2022 11:34
@mhmukadam mhmukadam added the bug Something isn't working label Apr 14, 2022
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@joeaortiz
Fixed dtype error in se3.py that came up in unit tests (facebookres…
581f13b 
…earch#158)

* fixed dtype error that appears in manifold_gaussian unit tests

* scalar tensor rather than full
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisenp luisenp luisenp approved these changes

@mhmukadam mhmukadam mhmukadam approved these changes

@fantaosha fantaosha fantaosha approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joeaortiz @fantaosha @luisenp @mhmukadam @facebook-github-bot