Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed device bug that occurred when merging info in TRUNCATED backward modes #181

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Fixed device bug that occurred when merging info in TRUNCATED backward modes #181

merged 1 commit into from
Apr 26, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Apr 26, 2022

No description provided.

@luisenp luisenp added the bug Something isn't working label Apr 26, 2022
@luisenp luisenp requested a review from mhmukadam April 26, 2022 20:01
@luisenp luisenp self-assigned this Apr 26, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 26, 2022
@luisenp luisenp changed the title Fixed device bug that occurred when merging infor in TRUNCATED backward modes Fixed device bug that occurred when merging info in TRUNCATED backward modes Apr 26, 2022
mhmukadam
mhmukadam approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@luisenp luisenp merged commit 733deff into main Apr 26, 2022
@luisenp luisenp deleted the lep.fix_info_merge_device branch April 26, 2022 23:31
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Fixed device bug that occurred when merging best info in TRUNCATED ba…
e86b1da 
…ckward modes. (facebookresearch#181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees

@luisenp luisenp

Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luisenp @mhmukadam @facebook-github-bot