Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added clearer explanation at the end of Tutorial 0 and fixed doc typos #2

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Added clearer explanation at the end of Tutorial 0 and fixed doc typos #2

merged 2 commits into from
Dec 6, 2021

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Dec 6, 2021

Also fixed typo in wget for motion planning example.

Motivation and Context

Documentation error

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@luisenp luisenp added the documentation Improvements or additions to documentation label Dec 6, 2021
@luisenp luisenp self-assigned this Dec 6, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2021
@luisenp luisenp changed the title Added clearer explanation at the end of Tutorial 0 Added clearer explanation at the end of Tutorial 0 and fixed doc typos Dec 6, 2021
@luisenp luisenp merged commit b0b01ea into main Dec 6, 2021
@luisenp luisenp deleted the lep.fix_documentation_typos branch December 6, 2021 21:44
ddetone pushed a commit that referenced this pull request Mar 29, 2022
@mhmukadam
Merge pull request #2 from fairinternal/create_variable_and_factor
97a9996 
Create variable and factor files in theseus.core
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Added clearer explanation at the end of Tutorial 0 and fixed doc typos (
8d0af23 
facebookresearch#2)

* Added clearer explanation at the end of Tutorial 0 and fixed typo in wget for motion planning example.

* Added license header to tactile_pose_estimation.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees

@luisenp luisenp

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luisenp @mhmukadam @facebook-github-bot