Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the new tensor from
cosine
is better, since our typical use case uses vmap over the optimization variable. The previous version could result in errors in AutodiffCostFunction in some corner cases (@rmurai0610 hit one of these). The caveat is that the new version will fail if we vmap over the points, but there is no easy workaround for this. From conversation with @zou3519 it seems thatfunctorch
team is working on some better API to lift tensors to their batched versions.