Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled back ellipsoidal damping in LM with linear solvers support checks #87

Merged
merged 7 commits into from
Mar 8, 2022
Merged

Enabled back ellipsoidal damping in LM with linear solvers support checks #87

merged 7 commits into from
Mar 8, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Feb 18, 2022

Motivation and Context

Closes #35

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2022
mhmukadam
mhmukadam approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, CI is failing though.

@luisenp
Copy link
Contributor Author

luisenp commented Feb 23, 2022 •
edited

@mhmukadam CI is failing due to #88, which I assigned to @maurimo. Forgot to cross link here.

mhmukadam
mhmukadam approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, can merge after the one open comment is resolved.

@facebookresearch facebookresearch deleted a comment from maurimo Mar 7, 2022
@luisenp luisenp merged commit 8dba61c into main Mar 8, 2022
@luisenp luisenp deleted the lep.ellipsoidal_damping_messages branch March 8, 2022 18:18
ddetone pushed a commit that referenced this pull request Mar 29, 2022
@luisenp
Merge pull request #87 from fairinternal/lep.fix_random_comments_upto86
bbf3f5e 
Fixed various comments for the previous PRs
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Enabled back ellipsoidal damping in LM with linear solvers support ch…
89b3d51 
…ecks (facebookresearch#87)

* Enabled back ellipsoidal damping in LM and added checks for supporting linear solvers.

* Fixed bad dtype handling in Objective and SparseLinearization.

* Renamed _LM_ALLOWED_SOLVERS to _LM_ALLOWED_ELLIPS_DAMP_SOLVERS.

* Changed nox so that pytest only runs 'not cudaext' market tests.

* Added batch_size kwarg to LUCudaSparseSolver.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

@maurimo maurimo Awaiting requested review from maurimo

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ellipsoidal damping for SparseSolver
4 participants
@luisenp @maurimo @mhmukadam @facebook-github-bot