-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled back ellipsoidal damping in LM with linear solvers support checks #87
Conversation
…g linear solvers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, CI is failing though.
@mhmukadam CI is failing due to #88, which I assigned to @maurimo. Forgot to cross link here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good, can merge after the one open comment is resolved.
Fixed various comments for the previous PRs
…ecks (facebookresearch#87) * Enabled back ellipsoidal damping in LM and added checks for supporting linear solvers. * Fixed bad dtype handling in Objective and SparseLinearization. * Renamed _LM_ALLOWED_SOLVERS to _LM_ALLOWED_ELLIPS_DAMP_SOLVERS. * Changed nox so that pytest only runs 'not cudaext' market tests. * Added batch_size kwarg to LUCudaSparseSolver.
Motivation and Context
Closes #35
How Has This Been Tested
Types of changes
Checklist