add support for stTheme #59
Conversation
also changed xml scope for better&faster read of colors + support
something like (<string><![CDATA[ html { position: relative; color:
#A83B40; } ]]></string>)
| "syntax_files": [], | ||
| "syntax_filter": "whitelist", | ||
| "base_scopes": ["text.xml"], | ||
| "scan_scopes": ["text.xml -meta.tag.xml -comment -string"], |
There was a problem hiding this comment.
I'm not okay with this change. Why not do something like this?
"scan_scopes": ["text.xml -meta.tag.xml -comment -string, string.unquoted.cdata.xml"],
|
because its not future proof, it means that with every time something new comes out u will have to update the settings. |
Very little in this world is.
I don't think the XML language changes very much and nor does the color schemes, and we never want to search comments. CDATA makes sense in the context of color schemes which is why I am okay with it. Comments and XML attribute strings don't. |
|
In my defense though, a setting file that can be easily updated when changes are needed does kind of make it future proof 😉 . It's all relative to the angle you are viewing it from. |
|
okay than. |
|
Is there a reason the issue got closed and not updated? I have no problems adding |
|
aaaaaa,okay ,my bad |
|
I was just reviewing the code, wasn't trying to shut this down 😉. |
|
point taken 👍 |
|
I just went ahead and manually merged what I wanted. |
2 participants
also changed xml scope for better&faster read of colors + support
something like