Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

themes? #69

Closed
kud opened this issue Aug 9, 2019 · 5 comments

Comments

@kud
Copy link

commented Aug 9, 2019

It could be great if there were a bunch of themes availables there. :D

@facelessuser

This comment has been minimized.

Copy link
Owner

commented Aug 9, 2019

The idea was to actually give consistent styling across plugins by using your current theme, with the option for plugins to provide some additional CSS for plugin specific controls.

When you say different styles, are you suggesting formatting and such? Or colors? For the latter, that kind of goes against what is attempting to addresses with this plugin.

With all of that said, a user can override the default CSS work anything they prefer.

I'm not entirely sure what specifically you'd like to see. Maybe a mock up might help?

@kud

This comment has been minimized.

Copy link
Author

commented Aug 9, 2019

You're right :)

I was just thinking about user contributions to have a better popup even if it's compliant to your theme.

@facelessuser

This comment has been minimized.

Copy link
Owner

commented Aug 9, 2019

I don't mind improving the pop-up, but I need to kind of see the improvement :).

@kud

This comment has been minimized.

Copy link
Author

commented Aug 9, 2019

I understand the I don't see neither the improvement in fact. I was just a bit lazy to custom myself the popup and wanted to see some community theme releases. :D

@facelessuser

This comment has been minimized.

Copy link
Owner

commented Aug 9, 2019

Since the default can be overridden, there could be community themes. You'd just have to use the settings to override the default. I wouldn't formally have them here, but I wouldn't mind printing people to them.

I'm also willing accept pulls for improved default popups :).

@kud kud closed this Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.