Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing zenpy.__version__ on setup.py causes installation errors #311

Closed
fmartingr opened this issue Mar 12, 2019 · 7 comments
Closed
Labels

Comments

@fmartingr
Copy link
Contributor

fmartingr commented Mar 12, 2019

Having zenpy imported on the setup.py tries to import all the references modules whitin it, failing because they are not yet installed.

The failing line:

from zenpy import __version__

Commit: fdae24b

➜ docker run -it --rm python:3 bash
root@adeca9e9e3c5:/# pip install zenpy==2.0.9
Collecting zenpy==2.0.9
  Downloading https://files.pythonhosted.org/packages/7c/28/176f813940586e4b90cd1771b1474c2516fdccc6b706dad73483c8070de2/zenpy-2.0.9.tar.gz (65kB)
    100% |████████████████████████████████| 71kB 720kB/s
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-nanrf1j_/zenpy/setup.py", line 3, in <module>
        from zenpy import __version__
      File "/tmp/pip-install-nanrf1j_/zenpy/zenpy/__init__.py", line 2, in <module>
        import requests
    ModuleNotFoundError: No module named 'requests'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-nanrf1j_/zenpy/

If you give me directions on how do you want his handled I can make a PR myself.

But the critical thing is that right now the 2.0.9 minor version is broken on pypi.

@facetoe
Copy link
Owner

facetoe commented Mar 12, 2019

Thanks for the report. This was added recently, I'm just going to remove the import.

@facetoe
Copy link
Owner

facetoe commented Mar 12, 2019

OK I've updated the version on PyPi, let me know if you still have issues installing.

@facetoe facetoe closed this as completed Mar 12, 2019
@fmartingr
Copy link
Contributor Author

@facetoe 2.0.10 works like a charm, thanks a lot for being so fast!

@facetoe
Copy link
Owner

facetoe commented Mar 12, 2019

No worries!

@insspb
Copy link
Contributor

insspb commented Mar 12, 2019

hmmm. Interesting why it was working on tests while I PR it... hm...

@facetoe
Copy link
Owner

facetoe commented Mar 12, 2019

I think this is only an issue on initial install.

@fmartingr
Copy link
Contributor Author

fmartingr commented Mar 12, 2019

On your local environment you already had the dependencies installed so the installation of the new dependencies gives no errors, and Travis may have environments cached as well... 😞

@facetoe facetoe added the bug label Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants