Skip to content

Commit

Permalink
Prevent Python 3 build dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
vbatoufflet committed Jul 16, 2015
1 parent d8d8738 commit c36c7f2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Expand Up @@ -7,7 +7,7 @@ go:

before_install:
- sudo apt-get update
- sudo apt-get install -qq python3 librrd-dev
- sudo apt-get install -qq librrd-dev

script:
- make test
Expand Down
5 changes: 3 additions & 2 deletions Makefile
Expand Up @@ -22,6 +22,9 @@ GOARCH ?= $(shell $(GO) env GOARCH)
BUILD_NAME = facette-$(GOOS)-$(GOARCH)
BUILD_DIR = build/$(BUILD_NAME)

GOPATH = $(realpath $(BUILD_DIR)):$(realpath vendor)
export GOPATH

TAR ?= tar

GOLINT ?= golint
Expand Down Expand Up @@ -112,7 +115,6 @@ PKG_SRC = $(wildcard pkg/*/*.go)
PKG_LIST = $(wildcard pkg/*)

$(BIN_OUTPUT): $(PKG_SRC) $(BIN_SRC) $(BUILD_DIR)/src/github.com/facette/facette
$(eval $(shell GOPATH=$(realpath $(BUILD_DIR)) vendor/vendorctl env))
@$(call mesg_start,$(notdir $@),Building $(notdir $@)...)
@install -d -m 0755 $(dir $@) && $(GO) build \
-ldflags " \
Expand Down Expand Up @@ -350,7 +352,6 @@ $(TEST_DIR):
@install -d -m 0755 $(TEST_DIR)

$(PKG_LIST): $(TEST_DIR) $(BUILD_DIR)/src/github.com/facette/facette
$(eval $(shell GOPATH=$(realpath $(BUILD_DIR)) vendor/vendorctl env))
@$(call mesg_start,test,Testing $@ package...)
@(cd $(TEST_DIR) && $(GO) test -race -c -i ../../../$@ && \
(test ! -f ./$(@:pkg/%=%).test || ./$(@:pkg/%=%).test -test.v=true) && \
Expand Down

1 comment on commit c36c7f2

@TomGudman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this changes properly removes the python3 dependency. Thank you Vincent!

Please sign in to comment.