Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 Breaking changes #10

Merged
merged 17 commits into from Sep 29, 2019

Conversation

@fachammer
Copy link
Owner

commented Sep 22, 2019

Include some breaking changes

  • better naming of node types
  • do not require whitespace between identifiers and just start parsing identifier when possible
fachammer added 3 commits Sep 22, 2019
BREAKING CHANGE: "source_file" node type is now called "lux".
This better reflects what is actually parsed because also ordinary
text could be parsed that doesn't come from a file and it signifies
that it's lux code.
Consumers should now expect a node of type "lux" where before
there was a node of type "source_file"
BREAKING CHANGE: Consumers should now expect a node of type "comment"
where before there was a node of type "inline_comment.
The specificity of "inline_comment" is unnecessary here as there is only one
type of comment in Lux
BREAKING CHANGE: Consumers should now expect a node of type "pair"
where before there was a node of type "record_pair".
The specificity of "record_pair" is unnecessary here as the pair can only
occur inside a record
@fachammer fachammer force-pushed the breaking-changes branch 2 times, most recently from b205be5 to 0e19d75 Sep 23, 2019
fachammer added 5 commits Sep 22, 2019
BREAKING CHANGE:
The following nodes were renamed. This change was made as the longer
canonical names better convey the meaning of the syntax token
  * nat -> natural
  * int -> integer
  * rev -> revolution
  * frac -> fraction
@fachammer fachammer force-pushed the breaking-changes branch from 0e19d75 to 7582b8d Sep 23, 2019
fachammer added 9 commits Sep 25, 2019
BREAKING CHANGE: between expressions there is now no strict need for
whitespace. This is in line with how Lux handles juxtaposition of
expressions, as it is not necessary to have whitespace when the parser
can figure out and pull apart the given expressions
it's not necessary to restrict to unit tests for local development as
the examples tests also run fast after some optimization was done
use longform name instead of abbreviation and use txt extension
for tests as in all other tests
add test cases for invalid tags and global access tags
@fachammer fachammer changed the title Breaking changes v2 Breaking changes Sep 29, 2019
@fachammer fachammer marked this pull request as ready for review Sep 29, 2019
@fachammer fachammer merged commit d4df063 into master Sep 29, 2019
6 checks passed
6 checks passed
pr-verifier Build #20190928.4 succeeded
Details
pr-verifier (build and test linux) build and test linux succeeded
Details
pr-verifier (build and test mac) build and test mac succeeded
Details
pr-verifier (build and test windows) build and test windows succeeded
Details
pr-verifier (dry run release) dry run release succeeded
Details
pr-verifier (verify commits) verify commits succeeded
Details
@fachammer fachammer deleted the breaking-changes branch Sep 29, 2019
@fachammer

This comment has been minimized.

Copy link
Owner Author

commented Sep 29, 2019

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fachammer fachammer added the released label Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.