From 11aa10adc9a3f56df908a37625b599389656266b Mon Sep 17 00:00:00 2001 From: Alessandro Lai Date: Thu, 21 Feb 2019 22:45:27 +0100 Subject: [PATCH] Remove uneeded PHPStan ignores --- phpstan.neon | 6 ------ tests/Unit/Process/ProcessFactoryTest.php | 11 ----------- 2 files changed, 17 deletions(-) diff --git a/phpstan.neon b/phpstan.neon index 26aecbdc..5cc3fa2f 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -1,14 +1,8 @@ parameters: ignoreErrors: - '/does not call parent constructor from PHPUnit\\Util\\Printer/' - # needed with Symfony <3.3 - - '/Call to function is_array\(\) with string will always evaluate to false./' - - '/Class Symfony\\Component\\EventDispatcher\\ContainerAwareEventDispatcher not found/' - '/Call to function method_exists.. with .Tests..BaseTestCase. and .assertStringContain.... will always evaluate to false./' excludes_analyse: - # needed with PHPUnit 6 - - src/Paraunit/Parser/JSON/LogPrinterV6.php - - src/Paraunit/Process/ProcessBuilderFactory.php - tests/Stub/ParseErrorTestStub.php includes: - vendor/phpstan/phpstan-phpunit/extension.neon diff --git a/tests/Unit/Process/ProcessFactoryTest.php b/tests/Unit/Process/ProcessFactoryTest.php index 2484afae..f7e0c119 100644 --- a/tests/Unit/Process/ProcessFactoryTest.php +++ b/tests/Unit/Process/ProcessFactoryTest.php @@ -9,21 +9,10 @@ use Paraunit\Process\AbstractParaunitProcess; use Paraunit\Process\CommandLine; use Paraunit\Process\ProcessFactory; -use Symfony\Component\Process\Process; use Tests\BaseUnitTestCase; class ProcessFactoryTest extends BaseUnitTestCase { - protected function setup(): void - { - $process = new Process(['cmd as array']); - if (\is_array($process->getCommandLine())) { - $this->markTestSkipped('CommandLine not parsed, we have symfony/process < 3.3'); - } - - parent::setUp(); - } - public function testCreateProcess() { $phpUnitConfig = $this->prophesize(PHPUnitConfig::class);