New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unsupported language/package versions #54

Closed
Jean85 opened this Issue Nov 9, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@Jean85
Member

Jean85 commented Nov 9, 2016

I would like to bump the supported versions for those deps with the 1.0 stable release:

  • PHPUnit ^6.0 (4.x drops support 2016-02-27, cross support is too hard)
  • Symfony ^2.7 || ^3.0
  • PHP ^7.0 (due to lack of support from PHPUnit 6)

This means also a few optimizations in the works:

  • support PHPUnit 6 (partially done with #86 )
  • use ::class everywhere
  • use array short syntax everywhere
  • use scalar and return typehint everywhere
  • use strict_types=1 everywhere
  • check for PHPUnit deprecations (setExpectedException, ...)
  • check for Symfony deprecations (maybe using symfony/phpunit-bridge)
  • drop Symfony/HttpKernel and the RegisterListenersPass workaround
  • disable skipping for RunnerTest::testWarning
  • remove check about presence of JSON_PRETTY_PRINT, it's there since 5.6.1
  • remove fallback versions of assertFile[Not]Exists
  • check that PHPUnit's options are correctly aligned with the 6.x version

@Jean85 Jean85 added the enhancement label Nov 9, 2016

@Jean85 Jean85 added this to the 1.0 milestone Nov 9, 2016

@Jean85 Jean85 self-assigned this Nov 9, 2016

@dxops

This comment has been minimized.

dxops commented Dec 29, 2016

PHP <5.6 (due to lack of support from PHPUnit 5)

It's supported up to PHPUnit 6, I'm not sure we need to drop it until PHP 5.6 EOL

@Jean85

This comment has been minimized.

Member

Jean85 commented Dec 29, 2016

It's < (less than) 5.6, so I will drop up to 5.5, following PHPUnit.

@alexmanno alexmanno removed this from the 1.0 milestone Dec 30, 2016

@Jean85 Jean85 added this to the 1.0 milestone Jan 8, 2017

@Jean85

This comment has been minimized.

Member

Jean85 commented Apr 6, 2017

Since I'm stuck with #89 and #92, I think I will give this a go, maybe it will help...

@Jean85

This comment has been minimized.

Member

Jean85 commented May 21, 2017

Trying to support both PHPUnit 5 and 6 is getting harder than it seemed. There are a lot of classes that do not have FC compatibility between those versions, and even those that have that, have issues (see sebastianbergmann/phpunit#2685 for example).

I'm thinking about bumping to a minimum of PHP 7 and PHPUnit 6. That should be a lot easier and we should gain scalar and return typehint.

Also, PHP 5.6 has left active support 4 months ago, and Paraunit 0.8.x will still hang around if needed...

@Jean85

This comment has been minimized.

Member

Jean85 commented May 26, 2017

After merging #93 and 286bf88 we can consider this done!

@Jean85 Jean85 closed this May 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment