Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid letting the colored console output blink (dots, errors) #124

Merged
merged 1 commit into from May 14, 2018

Conversation

@elegos
Copy link
Contributor

commented May 14, 2018

On bash 4.4.19 (Fedora 28) the text started blinking. Looking into the ConsoleFormatter I've noticed it's set to blink, but evidently for a bash bug (?) it wasn't and the output was looking good.

This pull request fixes this issue.

@Jean85

This comment has been minimized.

Copy link
Member

commented May 14, 2018

Woha, thanks a lot for spotting this!
Let me fix the CI first...

@Jean85 Jean85 closed this May 14, 2018
@Jean85 Jean85 reopened this May 14, 2018
@Jean85 Jean85 merged commit f91e619 into facile-it:master May 14, 2018
4 checks passed
4 checks passed
Scrutinizer No new issues
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Jean85

This comment has been minimized.

Copy link
Member

commented May 14, 2018

CI is green, merged, thanks again!

@elegos elegos deleted the elegos:feature/fix-blinking-output branch May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.