Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options without value are not working! #127

Merged
merged 4 commits into from Aug 11, 2018
Merged

Conversation

@fullbl
Copy link
Contributor

fullbl commented Aug 10, 2018

If a parameter without value (like --dont-report-useless-tests) is given, its value should not be passed to phpunit

fullbl added 4 commits Aug 10, 2018
…ven, its value should not be passed to phpunit
@fullbl

This comment has been minimized.

Copy link
Contributor Author

fullbl commented Aug 10, 2018

I think AppVeyor has problems with EOL :|

@Jean85
Jean85 approved these changes Aug 11, 2018
'command' => $command->getName(),
'--configuration' => $configurationPath,
'stringFilter' => 'green',
'--dont-report-useless-tests' => true,

This comment has been minimized.

Copy link
@Jean85

Jean85 Aug 11, 2018

Member

You should put a null here, to mimic better the CLI

@Jean85

This comment has been minimized.

Copy link
Member

Jean85 commented Aug 11, 2018

Regarding AppVeyor, I was using PHP_EOL exactly because it was working like that under Windows... WTF!

I'll fix it in a separate PR, thanks!

@Jean85 Jean85 added the bug label Aug 11, 2018
@Jean85 Jean85 merged commit 60955c6 into master Aug 11, 2018
4 of 6 checks passed
4 of 6 checks passed
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
Scrutinizer 1 updated code elements
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Jean85 Jean85 deleted the fix-command-option-without-value branch Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.