[BUG] Pool Configuration ignores ("forgets") peer group selection

[shake-spear]

Please prefix your issue title with one of the following: [BUG], [ISSUE], [FEATURE REQUEST], [MODULE REQUEST], [OTHER].

Replace everything between stars with current version of your facileManager and module installations:
fM Version : v3.5.7
fmDHCP Version : 0.4.4

In raising this issue, I confirm the following (please check boxes, eg [X]):

• I have read and understood the contributors guide.
• I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present.
• I have checked that the issue I'm posting isn't already reported.
• I have checked that the issue I'm posting isn't already solved and no duplicates exist in closed issues and opened issues
• I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.

---

(BUG | ISSUE) Expected Behavior:

(a) Select an existing and enabled failover peer (called "") on the "Pools Edit Config" of a pool
(b) Press "Save"
(c) Reopen "Pools Edit Config" of the same pool

=>
(I) The previously selected failover peer "" should be shown in the Drop-Down Box "Failover Peer"
(II) In the generated DHCP configfile the pool section of the mentioned pool should contain the line "failover peer ;"
pool {
failover peer ;
range 192.168.128.180 192.168.128.199;
default-lease-time 3600;
max-lease-time 86400;
allow unknown-clients;
}

(BUG | ISSUE) Actual Behavior:

(I) Drop-Down Box is empty
(II) line "failover peer ""; is missing in generated configfile
pool {
range 192.168.128.180 192.168.128.199;
default-lease-time 3600;
max-lease-time 86400;
allow unknown-clients;
}

(BUG | ISSUE) Steps to reproduce:

(a) Select an existing and enabled failover peer (called "") on the "Pools Edit Config" of a pool
(b) Press "Save"
(c) Reopen "Pools Edit Config" of the same pool

[WillyXJ]

I'm not able to reproduce this as I cannot create a peer without a name. Were you able to create an unnamed peer or is this as a result from an upgrade?

[shake-spear]

Oops - sry. During Copy&Paste the string enclosed by the double quotes got removed - silly me.
The peer has a name. The removed string was <peername> :)

[WillyXJ]

Got it and I'm able to reproduce it. Thanks.

[WillyXJ]

Would you please confirm that you've upgraded fmDHCP at least once or if this is a new installation of 0.4.4?

I've found new pools created with 0.4.4 do not exhibit this behavior.

[shake-spear]

Yes - I upgraded once
from
facilemanager-complete-3.5.6.tar.gz
to
facilemanager-complete-3.5.7.tar.gz

But I think (can't remember exactly anymore) I created the pools the first time with 0.4.4 - but this memory is blurry :)

[WillyXJ]

This is now fixed in fmDHCP 0.4.5 and later.