New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.98 is still not out #1783

Closed
slavapestov opened this Issue Jan 21, 2017 · 13 comments

Comments

Projects
None yet
5 participants
@slavapestov
Member

slavapestov commented Jan 21, 2017

C'mon @mrjbq7 :-)

@mrjbq7

This comment has been minimized.

Show comment
Hide comment
@mrjbq7

mrjbq7 Jan 21, 2017

Member

Hah! Yes, maybe let me revert the subseq? change, merge the GTK window drawing improvement and then think about a good stable 0.98 before we break more stuff with the new parser etc.

Member

mrjbq7 commented Jan 21, 2017

Hah! Yes, maybe let me revert the subseq? change, merge the GTK window drawing improvement and then think about a good stable 0.98 before we break more stuff with the new parser etc.

@slavapestov

This comment has been minimized.

Show comment
Hide comment
@slavapestov

slavapestov Jan 22, 2017

Member

You know you could call it 1.0 at this point. It's been 13 years :-)

Member

slavapestov commented Jan 22, 2017

You know you could call it 1.0 at this point. It's been 13 years :-)

@mrjbq7

This comment has been minimized.

Show comment
Hide comment
@mrjbq7

mrjbq7 Jan 22, 2017

Member

I'm looking forward to 0.100.

Member

mrjbq7 commented Jan 22, 2017

I'm looking forward to 0.100.

@bjourne

This comment has been minimized.

Show comment
Hide comment
@bjourne

bjourne Jan 22, 2017

Member

Perhaps we can try and get the linux 32bit build bot to work? It looks silly that it is crashing. :)

Member

bjourne commented Jan 22, 2017

Perhaps we can try and get the linux 32bit build bot to work? It looks silly that it is crashing. :)

@jonenst

This comment has been minimized.

Show comment
Hide comment
@jonenst

jonenst Jan 23, 2017

Contributor

What's the problem with the 32bit linux build bot ? Is there a full log somewhere ?
I did a bootstrap and load-all test-all on a 32bit xubuntu and it worked at baaa062 (only a few failures because of missing external dependencies like postgresql)

Contributor

jonenst commented Jan 23, 2017

What's the problem with the 32bit linux build bot ? Is there a full log somewhere ?
I did a bootstrap and load-all test-all on a 32bit xubuntu and it worked at baaa062 (only a few failures because of missing external dependencies like postgresql)

@jonenst

This comment has been minimized.

Show comment
Hide comment
@jonenst

jonenst Jan 23, 2017

Contributor

Oh wait, it did crash the UI listener interactor (not the window, I could still press F3 to open the test reports). I could still enter text, but the prefix "workspace" was missing and when pressing enter nothing happened.

I'm relaunching with ./factor -run=mason.test to see what happens without the UI listener

Here's the console log:

(factor:2143): Pango-WARNING **: Invalid UTF-8 string passed to pango_layout_set_text()

(factor:2143): Pango-WARNING **: Invalid UTF-8 string passed to pango_layout_set_text()
Error in thread 5331 (Test-write-file, [ yield "Hi" write ]):

Attempting to operate on disposed object
disposable T{ output-port f t f ~fd~ f ~buffer~ }

(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(O) Method: M\ output-port stream-write
(O) Word: already-disposed
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 5379 (Recursive monitor pump, [ ~recursive-monitor~ pump-thread ]):
Attempting to operate on disposed object
Unix system call “lstat” failed:~fd~ f ~buffer~ }

Aucun fichier ou dossier de ce type (2)chstack self quot>> call => stop ]
(O) Method: M\ output-port stream-write
It was called with the following arguments:
(O) Method: M\ object throw
"/tmp/factor-temp/doesnotexist"
S{ stat f 0 0 0 0 0 0 0 0 ~ushort-array~ 0 0 0 ~4 more~ }t-global
        current-continuation => error-continuation set-global
(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(O) Word: pump-thread
(O) Word: add-child-monitor
(O) Method: M\ unix link-info
(O) Word: link-status
(O) Word: unix-system-call-error
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 5417 (SSL server test, [ ~quotation~ 1 load-locals 0 get-local ~quotation~ curry 1...):

no-tls-supported


(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(U) Quotation: [ <test-secure-config> => swap with-secure-context ]
    Word: with-test-context
(O) Word: <test-secure-config>
(O) Word: <secure-config>
(O) Word: best-tls-method
(O) Word: no-tls-supported
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 5419 (SSL server test, [ ~quotation~ 1 load-locals 0 get-local ~quotation~ curry 1...):

no-tls-supported


(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(U) Quotation: [ <test-secure-config> => swap with-secure-context ]
    Word: with-test-context
(O) Word: <test-secure-config>
(O) Word: <secure-config>
(O) Word: best-tls-method
(O) Word: no-tls-supported
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 5421 (SSL server test, [ ~quotation~ 1 load-locals 0 get-local ~quotation~ curry 1...):

no-tls-supported


(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(U) Quotation: [ <test-secure-config> => swap with-secure-context ]
    Word: with-test-context
(O) Word: <test-secure-config>
(O) Word: <secure-config>
(O) Word: best-tls-method
(O) Word: no-tls-supported
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 11242 (Thread, [ ~array~ set-datastack ~promise~ 1 load-locals 0 get-local...):

no-tls-supported


(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(U) Quotation: [ <test-secure-config> => swap with-secure-context ]
    Word: with-test-context
(O) Word: <test-secure-config>
(O) Word: <secure-config>
(O) Word: best-tls-method
(O) Word: no-tls-supported
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 11256 (Thread, [ ~array~ set-datastack ~promise~ 1 load-locals 0 get-local...):

no-tls-supported


(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(U) Quotation: [ <test-secure-config> => swap with-secure-context ]
    Word: with-test-context
(O) Word: <test-secure-config>
(O) Word: <secure-config>
(O) Word: best-tls-method
(O) Word: no-tls-supported
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 12106 (Thread, [ ~array~ set-datastack ~promise~ 1 load-locals 0 get-local...):

no-tls-supported


(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(U) Quotation: [ <test-secure-config> => swap with-secure-context ]
    Word: with-test-context
(O) Word: <test-secure-config>
(O) Word: <secure-config>
(O) Word: best-tls-method
(O) Word: no-tls-supported
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Contributor

jonenst commented Jan 23, 2017

Oh wait, it did crash the UI listener interactor (not the window, I could still press F3 to open the test reports). I could still enter text, but the prefix "workspace" was missing and when pressing enter nothing happened.

I'm relaunching with ./factor -run=mason.test to see what happens without the UI listener

Here's the console log:

(factor:2143): Pango-WARNING **: Invalid UTF-8 string passed to pango_layout_set_text()

(factor:2143): Pango-WARNING **: Invalid UTF-8 string passed to pango_layout_set_text()
Error in thread 5331 (Test-write-file, [ yield "Hi" write ]):

Attempting to operate on disposed object
disposable T{ output-port f t f ~fd~ f ~buffer~ }

(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(O) Method: M\ output-port stream-write
(O) Word: already-disposed
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 5379 (Recursive monitor pump, [ ~recursive-monitor~ pump-thread ]):
Attempting to operate on disposed object
Unix system call “lstat” failed:~fd~ f ~buffer~ }

Aucun fichier ou dossier de ce type (2)chstack self quot>> call => stop ]
(O) Method: M\ output-port stream-write
It was called with the following arguments:
(O) Method: M\ object throw
"/tmp/factor-temp/doesnotexist"
S{ stat f 0 0 0 0 0 0 0 0 ~ushort-array~ 0 0 0 ~4 more~ }t-global
        current-continuation => error-continuation set-global
(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(O) Word: pump-thread
(O) Word: add-child-monitor
(O) Method: M\ unix link-info
(O) Word: link-status
(O) Word: unix-system-call-error
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 5417 (SSL server test, [ ~quotation~ 1 load-locals 0 get-local ~quotation~ curry 1...):

no-tls-supported


(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(U) Quotation: [ <test-secure-config> => swap with-secure-context ]
    Word: with-test-context
(O) Word: <test-secure-config>
(O) Word: <secure-config>
(O) Word: best-tls-method
(O) Word: no-tls-supported
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 5419 (SSL server test, [ ~quotation~ 1 load-locals 0 get-local ~quotation~ curry 1...):

no-tls-supported


(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(U) Quotation: [ <test-secure-config> => swap with-secure-context ]
    Word: with-test-context
(O) Word: <test-secure-config>
(O) Word: <secure-config>
(O) Word: best-tls-method
(O) Word: no-tls-supported
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 5421 (SSL server test, [ ~quotation~ 1 load-locals 0 get-local ~quotation~ curry 1...):

no-tls-supported


(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(U) Quotation: [ <test-secure-config> => swap with-secure-context ]
    Word: with-test-context
(O) Word: <test-secure-config>
(O) Word: <secure-config>
(O) Word: best-tls-method
(O) Word: no-tls-supported
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 11242 (Thread, [ ~array~ set-datastack ~promise~ 1 load-locals 0 get-local...):

no-tls-supported


(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(U) Quotation: [ <test-secure-config> => swap with-secure-context ]
    Word: with-test-context
(O) Word: <test-secure-config>
(O) Word: <secure-config>
(O) Word: best-tls-method
(O) Word: no-tls-supported
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 11256 (Thread, [ ~array~ set-datastack ~promise~ 1 load-locals 0 get-local...):

no-tls-supported


(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(U) Quotation: [ <test-secure-config> => swap with-secure-context ]
    Word: with-test-context
(O) Word: <test-secure-config>
(O) Word: <secure-config>
(O) Word: best-tls-method
(O) Word: no-tls-supported
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
Error in thread 12106 (Thread, [ ~array~ set-datastack ~promise~ 1 load-locals 0 get-local...):

no-tls-supported


(U) Quotation: [ set-namestack init-catchstack self quot>> call => stop ]
(U) Quotation: [ <test-secure-config> => swap with-secure-context ]
    Word: with-test-context
(O) Word: <test-secure-config>
(O) Word: <secure-config>
(O) Word: best-tls-method
(O) Word: no-tls-supported
(O) Method: M\ object throw
(U) Quotation: [
        OBJ-CURRENT-THREAD special-object error-thread set-global
        current-continuation => error-continuation set-global
        [ original-error set-global ] [ rethrow ] bi
    ]
@mrjbq7

This comment has been minimized.

Show comment
Hide comment
@mrjbq7

mrjbq7 Jan 23, 2017

Member

Is linux-32 not working? Or is the buildbot just not running?

Member

mrjbq7 commented Jan 23, 2017

Is linux-32 not working? Or is the buildbot just not running?

@jonenst

This comment has been minimized.

Show comment
Hide comment
@jonenst

jonenst Jan 23, 2017

Contributor

linux-32 works. launching ./factor -run=mason.test (ie no GUI listener), the process exists with 0, almost all tests are OK (including all dependencies, like postgresql, forestdb imap etc). Using the GUI listener also works. So it's probably a problem with the build bot.

Note:
Failures are basis:alien.library.finder.linux because it looks for "OS ABI" and got "Système d'exploitation ABI" with a french locale; also bunny got image-too-big actual-size 2592540 max-size 2590476, maybe because I had "saved" my image after saving imap configs and postgresql configs ?)

Contributor

jonenst commented Jan 23, 2017

linux-32 works. launching ./factor -run=mason.test (ie no GUI listener), the process exists with 0, almost all tests are OK (including all dependencies, like postgresql, forestdb imap etc). Using the GUI listener also works. So it's probably a problem with the build bot.

Note:
Failures are basis:alien.library.finder.linux because it looks for "OS ABI" and got "Système d'exploitation ABI" with a french locale; also bunny got image-too-big actual-size 2592540 max-size 2590476, maybe because I had "saved" my image after saving imap configs and postgresql configs ?)

@mrjbq7

This comment has been minimized.

Show comment
Hide comment
@mrjbq7

mrjbq7 Jan 23, 2017

Member

Does this work on alien.libraries.finder.linux:

diff --git a/basis/alien/libraries/finder/linux/linux.factor b/basis/alien/libraries/finder/linux/linux.factor
index d21b1b0dd1..a0decd3754 100644
--- a/basis/alien/libraries/finder/linux/linux.factor
+++ b/basis/alien/libraries/finder/linux/linux.factor
@@ -20,7 +20,7 @@ CONSTANT: mach-map {
         [
             " " split1 [ "()" in? ] trim "," split
             [ [ blank? ] trim ] map
-            [ "OS ABI:" head? ] reject
+            [ "ABI:" swap subseq? ] reject
         ] dip 3array
     ] map ;
Member

mrjbq7 commented Jan 23, 2017

Does this work on alien.libraries.finder.linux:

diff --git a/basis/alien/libraries/finder/linux/linux.factor b/basis/alien/libraries/finder/linux/linux.factor
index d21b1b0dd1..a0decd3754 100644
--- a/basis/alien/libraries/finder/linux/linux.factor
+++ b/basis/alien/libraries/finder/linux/linux.factor
@@ -20,7 +20,7 @@ CONSTANT: mach-map {
         [
             " " split1 [ "()" in? ] trim "," split
             [ [ blank? ] trim ] map
-            [ "OS ABI:" head? ] reject
+            [ "ABI:" swap subseq? ] reject
         ] dip 3array
     ] map ;
@jonenst

This comment has been minimized.

Show comment
Hide comment
@jonenst

jonenst Jan 24, 2017

Contributor

From the glibc source code:

be.po-msgstr ""
bg.po-msgstr ", ОС ДПИ(двоичен програмен интерфейс): %s %d.%d.%d"
ca.po-msgstr ", ABI del SO: %s %d.%d.%d"
cs.po-msgstr ", ABI OS: %s %d.%d.%d"
da.po:msgstr ", OS ABI: %s %d.%d.%d"
de.po:msgstr ", OS ABI: %s %d.%d.%d"
eo.po-msgstr ", mastruma ABI-o: %s %d.%d.%d"
es.po-msgstr ", ABI del SO: %s %d.%d.%d"
fi.po:msgstr ", OS ABI: %s %d.%d.%d"
fr.po-msgstr ", Système d'exploitation ABI : %s %d.%d.%d"
gl.po:msgstr ", OS ABI: %s %d.%d.%d"
hr.po:msgstr ", OS ABI: %s %d.%d.%d"
hu.po:msgstr ", OS ABI: %s %d.%d.%d"
ia.po-msgstr ", ABI del systema operative: %s %d.%d.%d"
id.po:msgstr ", OS ABI: %s %d.%d.%d"
it.po-msgstr ", ABI del sistema operativo: %s %d.%d.%d"
ja.po:msgstr ", OS ABI: %s %d.%d.%d"
ko.po:msgstr ", OS ABI: %s %d.%d.%d"
libc.pot-msgstr ""
lt.po:msgstr ", OS ABI: %s %d.%d.%d"
nb.po-msgstr ""
nl.po-msgstr ", OS-ABI: %s %d.%d.%d"
pl.po-msgstr ", ABI systemu: %s %d.%d.%d"
ru.po-msgstr ", ABI ОС: %s %d.%d.%d"
rw.po-msgstr ""
sk.po:msgstr ", OS ABI: %s %d.%d.%d"
sl.po:msgstr ", OS ABI: %s %d.%d.%d"
sv.po:msgstr ", OS ABI: %s %d.%d.%d"
tr.po:msgstr ", OS ABI: %s %d.%d.%d"
uk.po-msgstr ", ABI ОС: %s %d.%d.%d"
vi.po:msgstr ", OS ABI: %s %d.%d.%d"
zh_CN.po:msgstr ", OS ABI: %s %d.%d.%d"
zh_TW.po:msgstr ", OS ABI: %s %d.%d.%d"

So I think the best way to detect this message is to look for "Linux" ? Or maybe the leading comma-space ? But I think "Linux" is more resistant?

libBrokenLocale.so (libc6,x86-64, OS ABI: Linux 2.6.24) => /usr/lib/x86_64-linux-gnu/libBrokenLocale.so
Contributor

jonenst commented Jan 24, 2017

From the glibc source code:

be.po-msgstr ""
bg.po-msgstr ", ОС ДПИ(двоичен програмен интерфейс): %s %d.%d.%d"
ca.po-msgstr ", ABI del SO: %s %d.%d.%d"
cs.po-msgstr ", ABI OS: %s %d.%d.%d"
da.po:msgstr ", OS ABI: %s %d.%d.%d"
de.po:msgstr ", OS ABI: %s %d.%d.%d"
eo.po-msgstr ", mastruma ABI-o: %s %d.%d.%d"
es.po-msgstr ", ABI del SO: %s %d.%d.%d"
fi.po:msgstr ", OS ABI: %s %d.%d.%d"
fr.po-msgstr ", Système d'exploitation ABI : %s %d.%d.%d"
gl.po:msgstr ", OS ABI: %s %d.%d.%d"
hr.po:msgstr ", OS ABI: %s %d.%d.%d"
hu.po:msgstr ", OS ABI: %s %d.%d.%d"
ia.po-msgstr ", ABI del systema operative: %s %d.%d.%d"
id.po:msgstr ", OS ABI: %s %d.%d.%d"
it.po-msgstr ", ABI del sistema operativo: %s %d.%d.%d"
ja.po:msgstr ", OS ABI: %s %d.%d.%d"
ko.po:msgstr ", OS ABI: %s %d.%d.%d"
libc.pot-msgstr ""
lt.po:msgstr ", OS ABI: %s %d.%d.%d"
nb.po-msgstr ""
nl.po-msgstr ", OS-ABI: %s %d.%d.%d"
pl.po-msgstr ", ABI systemu: %s %d.%d.%d"
ru.po-msgstr ", ABI ОС: %s %d.%d.%d"
rw.po-msgstr ""
sk.po:msgstr ", OS ABI: %s %d.%d.%d"
sl.po:msgstr ", OS ABI: %s %d.%d.%d"
sv.po:msgstr ", OS ABI: %s %d.%d.%d"
tr.po:msgstr ", OS ABI: %s %d.%d.%d"
uk.po-msgstr ", ABI ОС: %s %d.%d.%d"
vi.po:msgstr ", OS ABI: %s %d.%d.%d"
zh_CN.po:msgstr ", OS ABI: %s %d.%d.%d"
zh_TW.po:msgstr ", OS ABI: %s %d.%d.%d"

So I think the best way to detect this message is to look for "Linux" ? Or maybe the leading comma-space ? But I think "Linux" is more resistant?

libBrokenLocale.so (libc6,x86-64, OS ABI: Linux 2.6.24) => /usr/lib/x86_64-linux-gnu/libBrokenLocale.so
@bjourne

This comment has been minimized.

Show comment
Hide comment
@bjourne

bjourne Jan 24, 2017

Member

Are we really trying to parse i18n:ized output? If so, that is not right. We should either call LOCALE=C ldconfig -p or perhaps parse /etc/ld.so.cache directly.

Member

bjourne commented Jan 24, 2017

Are we really trying to parse i18n:ized output? If so, that is not right. We should either call LOCALE=C ldconfig -p or perhaps parse /etc/ld.so.cache directly.

@mrjbq7

This comment has been minimized.

Show comment
Hide comment
@mrjbq7

mrjbq7 Jan 24, 2017

Member

It's just to ignore some of the lines in the current algorithm.

Member

mrjbq7 commented Jan 24, 2017

It's just to ignore some of the lines in the current algorithm.

@erg erg added this to the 0.98 milestone Dec 30, 2017

@mrjbq7 mrjbq7 modified the milestones: 0.98, 0.99 Dec 30, 2017

@erg erg added release meta labels Jan 23, 2018

@mrjbq7

This comment has been minimized.

Show comment
Hide comment
@mrjbq7

mrjbq7 Jul 31, 2018

Member

Amazing that we didn't pause for a release for almost 4 years.

Member

mrjbq7 commented Jul 31, 2018

Amazing that we didn't pause for a release for almost 4 years.

@mrjbq7 mrjbq7 closed this Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment