Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows crlf <-> lf failure #1916

Closed
bjourne opened this issue Jan 23, 2018 · 2 comments
Closed

Windows crlf <-> lf failure #1916

bjourne opened this issue Jan 23, 2018 · 2 comments
Labels
git unit-test windows

Comments

@bjourne
Copy link
Member

bjourne commented Jan 23, 2018 

Unit Test: { { t } [ "example" test-template ] }
"\n<!DOCTYPE html>\n<html>\n    <head><title>Simple Embedded Fact..."
"\n<!DOCTYPE html>\n<html>\n    <head><title>Simple Embedded Fact..."
Unit Test: { { t } [ "stack" test-template ] }
"The stack: \r\n"
"The stack: \n"
--> test failed!
Unit Test: { { t } [ "bug" test-template ] }
"5\r\n"
"5\n"
--> test failed!

I think it is because git performs line ending conversions on checkout. So I think we should add *.html binary to .gitattributes or something. But I'm not sure.
@alex-ilin
Copy link
Member

We already have *.factor text eol=lf
I think we should add *.html text eol=lf

@bjourne
Copy link
Member Author

bjourne commented Jan 23, 2018

Yup, that would work as well.

alex-ilin added a commit to alex-ilin/factor that referenced this issue Feb 24, 2018
@alex-ilin
.gitattributes: add the eol=lf attribute to html-files (fixes factor#…
b1d1431 
…1916)
@erg erg closed this as completed in 0fa8996 Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
git unit-test windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erg @bjourne @alex-ilin