Prelude and jQuery

[jeremyescott]

I don't know if this so much an issue as a question/concern.

Prelude replaces core WP jQuery. A lot of people see that as a huge no-no. eg: https://pippinsplugins.com/why-loading-your-own-jquery-is-irresponsible/

I see that the wrap for using the Google library version checks for admin, but that causes me to pause and consider, "why then?" If js must be written for two versions of jQuery, why not allow the default library to load?

I'd love to hear your thoughts on this.

[erwstout]

Good looking out. I think, to be honest, its just a relic of when we had less of a handle on developing for WordPress back a few years ago and just never had any issues with it (developing in a "bubble" will do that to you). How it works now, is that if you're not an admin it loads the google version. Which is/was what we wanted at the time, but I can now see how this could negatively impact plugin developers. (Most of our plugins we do build only do front-end work).

I'm going to take a look at removing this on Monday - and run some tests, but I think it's safe to say that by the end of the week it will be removed. Not sure if @mattada or @bebaps have any other input on the matter.

[erwstout]

Also, congrats (??) on opening issue #100! :-)

[jeremyescott]

I'll celebrate #100 in the only way I know best... beer!

[bebaps]

This was in the codebase for as long as I have been here, but yes it is not needed. I can guess that it was done just to use an updated version of jQuery. WordPress suggests not using a CDN or external link to pull jQuery anyway, so if you do need an updated version in the theme just include it in the JS build process.

I say get rid of it, but just be sure to check jQuery versions needed for any third party plugins in use (Slick, Remodal, etc). An updated version of jQuery can be added as a dependency in the package.json but leave it up to the developer to use it.

[erwstout]

Boom. Done. Just make sure when adding scripts that rely on jQuery its in the deps array such as what we now do by default:

wp_enqueue_script('prelude-js', get_template_directory_uri() . '/assets/js/theme.min.js', array('jquery'), THEME_VERSION, true );