Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intent.util.DelayedFutureTest failure #44

Closed
bishabosha opened this issue Jan 8, 2020 · 5 comments
Closed

intent.util.DelayedFutureTest failure #44

bishabosha opened this issue Jan 8, 2020 · 5 comments
Assignees

Comments

@bishabosha
Copy link
Contributor

This failed in the Dotty community build (currently based on 989f238)

[info] [FAILED] intent.util.DelayedFutureTest >> A DelayedFuture >> should be cancellable (383 ms)
[info] 	Expected false but found true (/tmp/3/community-build/community-projects/intent/src/test/scala/intent/util/DelayedFutureTest.scala:47:32)
[info] [FAILED] intent.util.DelayedFutureTest >> A DelayedFuture >> should have a default result after being cancelled (382 ms)
[info] 	Expected 0 but found 42 (/tmp/3/community-build/community-projects/intent/src/test/scala/intent/util/DelayedFutureTest.scala:55:35)
@provegard
Copy link
Collaborator

Thanks, we'll look into it.

@eliasson
Copy link
Contributor

I failed to reproduce the error in the community build, but I am not sure I set everything up correctly.

Here is what I did:

git clone git@github.com:dotty-staging/dotty.git
git checkout change-extmethods3
git submodule update --init --recursive

I edited community-build/test/scala/dotty/communitybuild/CommunityBuildTest.scala to comment out all tests but intent and then ran the tests multiple times.

sbt community-build/test
…
> [info] Passed: Total 201, Failed 0, Errors 0, Passed 201, Ignored 1

I assumed this would compile and use the correct version of the dotty compiler? @bishabosha does it look correct to you?

To rule out any intermittent error I plan to run the test continously until failure later tonight using

while sbt community-build/test; do :; done

@eliasson eliasson self-assigned this Jan 10, 2020
@eliasson
Copy link
Contributor

I realized that I forgot to update this thread. I ran the test continuously for a few hours during the weekend and could not reproduce this issue.

I noticed that the Dotty PR #7917 reporting this issue has been merged now and that Intent built without errors as well.

Maybe this was an intermittent timing issue?

@bishabosha
Copy link
Contributor Author

bishabosha commented Jan 15, 2020

Yes it does seem pretty rare. The Drone instance we've been running the tests often has issues related to thread sleeping, so Im not sure which part of the entire stack is at fault

@eliasson
Copy link
Contributor

Ok, I’ll leave this open for while longer to see if we can reproduce it somehow.

Let us know if it occures in your drone build again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants