Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: unwanted line breaks #287

Closed
stmh opened this issue Sep 24, 2022 · 2 comments
Closed

docs: unwanted line breaks #287

stmh opened this issue Sep 24, 2022 · 2 comments
Assignees

Comments

@stmh
Copy link
Member

stmh commented Sep 24, 2022

the markdown implementation treats linefeeds differently to the standard:

Phab 3.8 contains a new command named `find:property` which provides a visual prompt where the user can start typing the
name of a property they are interested in. Phab supports you by offering properties via autocomplete. As an alternative
you can hit enter to get a list of suggestions. After you found the property you are interested in, hit return, and phab
will display the actual value of that property, its ancestors and from where it got read.

gets rendered with line breaks after every source-line:
CleanShot 2022-09-24 at 16 06 29@2x

According to the markdown spec this shouldn't happen, if you want to add a line break, you need to add 2 spaces. (See also: https://gist.github.com/shaunlebron/746476e6e7a4d698b373)

Is this configurable per project? if so how?

@mgrsskls
Copy link
Member

Ah, thanks for the hint! That was a simple internal setting which is not configurable though. PR: #288

stmh added a commit that referenced this issue Sep 25, 2022
chore: Updates @factorial/docs to fix line breaks (#287)
@stmh
Copy link
Member Author

stmh commented Sep 25, 2022

thanks!

@stmh stmh closed this as completed Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants