Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill date pickers #159

Merged
merged 1 commit into from Apr 7, 2019
Merged

Kill date pickers #159

merged 1 commit into from Apr 7, 2019

Conversation

@tcbegley
Copy link
Member

tcbegley commented Mar 21, 2019

This PR removes DatePickerSingle and DatePickerRange as suggested in #148. It appears to have reduced the bundle size by about two thirds (!) from ~750KB to ~250KB.

@tcbegley

This comment has been minimized.

Copy link
Member Author

tcbegley commented Mar 21, 2019

While looking into ramda imports as suggested here I noticed that these two components were also the only places we were using ramda without targeted imports, so possibly a large chunk of the reduction we're getting is due to the blanket imports getting removed.

@pbugnion

This comment has been minimized.

Copy link
Member

pbugnion commented Apr 5, 2019

To help people use DatePicker{Single,Range} from dash-core-components, should we write an example in the documentation somewhere? The deprecation exception could then point to that?

@pbugnion

This comment has been minimized.

Copy link
Member

pbugnion commented Apr 5, 2019

Apart from that, this looks good.

@tcbegley

This comment has been minimized.

Copy link
Member Author

tcbegley commented Apr 5, 2019

To help people use DatePicker{Single,Range} from dash-core-components, should we write an example in the documentation somewhere? The deprecation exception could then point to that?

We could just link to the dash-core-components docs? I'm not sure that our own documentation would add much?

@tcbegley tcbegley merged commit 8ecf4b3 into master Apr 7, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tcbegley tcbegley deleted the kill-datepickers branch Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.