-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for React 16 #177
Updates for React 16 #177
Conversation
On modals, I expect people will spend a ton of time writing annoying little callbacks like: @app.callback(
Output("modal", "is_open"),
[Input("open", "n_clicks"), Input("close", "n_clicks")],
[State("modal", "is_open")],
)
def toggle_modal(n1, n2, is_open):
if n1 or n2:
return not is_open
return is_open Could we potentially provide a function like: dbc.interaction.bind_modal_callbacks(app, 'modal') ? (we could imagine similar callbacks in the I don't think that's in scope for this PR, but it might be worth considering. |
This looks great! Modulo a couple of comments inline, merge whenever! I think modals and spinners will be a great addition. |
* Add option to right align the dropdown menu * Add right-aligment to docs
Thanks for reviewing! I think your |
With the release of dash 0.41.0 and dash-renderer 0.22.0, dash-renderer is now using React 16, meaning the work that was happening on the dash-v1 branch can be merged.
Changes include:
Modal
components + documentation (Add modals #146)Spinner
component + documentation (Add spinners #161)DropdownMenu
(Right-aligned menu #139)I made a prerelease for testing: