Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CardTitle, CardSubtitle, CardText #193

Merged
merged 1 commit into from
May 10, 2019

Conversation

tcbegley
Copy link
Collaborator

This PR addresses #187 by removing the CardTitle, CardSubtitle and CardText components.

An update to reactstrap meant that these components were essentially just heavy-handed ways of adding some margins to HTML elements, so I think it's best to encourage people to apply the relevant CSS classes manually instead.

@tcbegley tcbegley mentioned this pull request Apr 30, 2019
@tcbegley tcbegley merged commit 21091a7 into master May 10, 2019
@tcbegley tcbegley deleted the kill-cardtitle-cardsubtitle branch May 10, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant