Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose color, style and className for DropdownMenu toggle #221

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Expose color, style and className for DropdownMenu toggle #221

merged 1 commit into from
Jun 27, 2019

Conversation

tcbegley
Copy link
Collaborator

This PR addresses #220 by adding three new props to DropdownMenu: color, toggle_style and toggleClassName, to give users more control over the style of the toggle that gets rendered by DropdownMenu.

@tcbegley tcbegley mentioned this pull request Jun 11, 2019
Closed
@tcbegley
Copy link
Collaborator Author

tcbegley commented Jun 27, 2019 •
edited
Loading

Added menuClassName and menu_style to this PR to allow styling of the menu itself.

Seems if you supply style arguments to reactstrap's DropdownMenu it breaks the positioning of the menu when using directions other than "down", so not going to expose this for now.

@tcbegley tcbegley mentioned this pull request Jun 27, 2019
Merged
@tcbegley tcbegley force-pushed the dropdownmenu-color branch from 3ccd850 to c0a1bba Compare June 27, 2019 08:00
@tcbegley tcbegley merged commit 293e016 into master Jun 27, 2019
@tcbegley tcbegley deleted the dropdownmenu-color branch June 27, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tcbegley