Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent setProps being passed to DOM elements #264

Merged
merged 1 commit into from Oct 20, 2019
Merged

Prevent setProps being passed to DOM elements #264

merged 1 commit into from Oct 20, 2019

Conversation

tcbegley
Copy link
Collaborator

@tcbegley tcbegley commented Oct 20, 2019

This PR ensures that setProps is not passed on to DOM elements by our components, which was causing error messages to appear in the console. I used omit from ramda since we were already using it to do this in the implementation of Input.

@tcbegley tcbegley merged commit 23edc7c into master Oct 20, 2019
@tcbegley tcbegley deleted the setprops branch Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant