Fix DropdownMenu dismissal #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcbegley
force-pushed
the
dropdownmenu-dismiss
branch
from
07d0fa5
to
8e83fd8
Compare
|
This can be tested out with |
Previously DropdownMenuItems that were being used as internal links did not correctly dismiss the dropdown menu. This is because the internal links call preventDefault on the click event to stop the page from refreshing. However this would stop the event from reaching the underlying reactstrap component which would handle the dismissal. This fix checks if the DropdownMenuItem is being used as an internal link, and if so takes care of dismissing the DropdownMenu itself. To give users even more control, DropdownMenuItem now has a new prop toggle, True by default, which determines whether clicking on the item dismisses the menu.
tcbegley
force-pushed
the
dropdownmenu-dismiss
branch
from
8e83fd8
to
1de90b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
DropdownMenuItems that were being used as internal links did not correctly dismiss the dropdown menu. This is because the internal links callpreventDefaulton the click event to stop the page from refreshing. However this would stop the event from reaching the underlying reactstrap component which would handle the dismissal.This fix checks if the
DropdownMenuItemis being used as an internal link, and if so takes care of dismissing theDropdownMenuitself.To give users even more control, DropdownMenuItem now has a new prop
toggle(Trueby default), which determines whether clicking on the item dismisses the menu.This addresses #287