Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Input Validation #299

Merged
merged 2 commits into from Jan 8, 2020
Merged

Fix Input Validation #299

merged 2 commits into from Jan 8, 2020

Conversation

benpgreen
Copy link
Collaborator

@benpgreen benpgreen commented Jan 8, 2020

This PR fixes a bug where zero values were being converted to null values in the Input component when the type property was set to "number".

@benpgreen
Copy link
Collaborator Author

@benpgreen benpgreen commented Jan 8, 2020

LGTM now @tcbegley

@tcbegley tcbegley self-requested a review Jan 8, 2020
Copy link
Collaborator

@tcbegley tcbegley left a comment

Thanks @benpgreen!

@tcbegley tcbegley merged commit 34a6963 into facultyai:master Jan 8, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants