Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Input Validation #299

Merged
merged 2 commits into from Jan 8, 2020
Merged

Fix Input Validation #299

merged 2 commits into from Jan 8, 2020

Conversation

@benpgreen
Copy link
Contributor

benpgreen commented Jan 8, 2020

This PR fixes a bug where zero values were being converted to null values in the Input component when the type property was set to "number".

@benpgreen

This comment has been minimized.

Copy link
Contributor Author

benpgreen commented Jan 8, 2020

LGTM now @tcbegley

@tcbegley tcbegley self-requested a review Jan 8, 2020
Copy link
Member

tcbegley left a comment

Thanks @benpgreen!

@tcbegley tcbegley merged commit 34a6963 into facultyai:master Jan 8, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.