Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve link components #315

Merged
merged 1 commit into from Feb 18, 2020
Merged

Improve link components #315

merged 1 commit into from Feb 18, 2020

Conversation

tcbegley
Copy link
Collaborator

@tcbegley tcbegley commented Feb 18, 2020

This PR makes some improvements to link based components, in particular ensuring that isExternalLink in Link won't fail if no href is supplied, and making sure that the appropriate fallback elements as used if Link isn't used.

@tcbegley tcbegley merged commit 9e0cf6e into master Feb 18, 2020
2 checks passed
@tcbegley tcbegley deleted the navlink-fix branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant