Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default tab fix #405

Merged
merged 3 commits into from Jun 13, 2020
Merged

Default tab fix #405

merged 3 commits into from Jun 13, 2020

Conversation

tcbegley
Copy link
Collaborator

@tcbegley tcbegley commented Jun 12, 2020

When using Tabs, if active_tab is initially unspecified the first tab is chosen for you as the default active tab. Previously however the active_tab prop was not updated to this default value, leading to an issue when using callbacks to dynamically render tab content. This PR adds a call to setProps on initialisation to make sure everything stays in sync.

It also updates the graphs_in_tabs example to ensure dictionaries are not passed to the children of a component.

Closes #404

@tcbegley tcbegley merged commit 799804d into master Jun 13, 2020
2 checks passed
@tcbegley tcbegley deleted the default-tab-fix branch Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant