Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep children in layout when spinner is loading. Tests updated #465

Merged
merged 2 commits into from Nov 11, 2020
Merged

Keep children in layout when spinner is loading. Tests updated #465

merged 2 commits into from Nov 11, 2020

Conversation

Jason-AM
Copy link
Collaborator

No description provided.

@tcbegley
Copy link
Collaborator

Addresses issue raised in #463

tcbegley
tcbegley approved these changes Nov 7, 2020
View reviewed changes
Copy link
Collaborator

@tcbegley tcbegley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Was there something else left to do?

@Jason-AM
Copy link
Collaborator Author

I think that was all the required work. Should be good to go.

@Jason-AM Jason-AM closed this Nov 10, 2020
@Jason-AM Jason-AM reopened this Nov 10, 2020
@tcbegley tcbegley merged commit a48103e into master Nov 11, 2020
@tcbegley tcbegley deleted the jason/spinner branch November 11, 2020 08:01
This was referenced Dec 13, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcbegley tcbegley tcbegley approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jason-AM @tcbegley